Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amesos2: Fix NNZ/row in KLU2 unit test #5846

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Amesos2: Fix NNZ/row in KLU2 unit test #5846

merged 1 commit into from
Sep 3, 2019

Conversation

brian-kelley
Copy link
Contributor

Correct the value of max nonzeros per row from 1 to 2
in the KLU2 unit test "NumericFactorizationNullThrows".

@trilinos/amesos2

Description

Just fixed max nnz/row for static profile. This test adds diagonal entries, and then adds entries in opposite corners, so max nnz is 2.

Motivation and Context

Makes the test pass when Tpetra deprecated is off.

How Has This Been Tested?

Built and run with Tpetra_ENABLE_DEPRECATED_CODE=OFF

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@brian-kelley
Amesos2: Fix NNZ/row in KLU2 unit test
843c5b3 
Correct the value of max nonzeros per row from 1 to 2
in the KLU2 unit test "NumericFactorizationNullThrows".
@brian-kelley brian-kelley requested a review from tjfulle September 3, 2019 20:15
@brian-kelley brian-kelley added pkg: Amesos2 impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) labels Sep 3, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4417
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4241
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2678
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2502
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2079
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 517
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 517
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Using Repos:

Repo: TRILINOS (brian-kelley/Trilinos)
  • Branch: KLU_TpetraDeprecation
  • SHA: 843c5b3
  • Mode: TEST_REPO

Pull Request Author: brian-kelley

@brian-kelley brian-kelley added the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Sep 3, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 4417
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 4241
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 2678
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 2502
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 2079
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_python_2

  • Build Num: 517
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183

Build Information

Test Name: Trilinos_pullrequest_python_3

  • Build Num: 517
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 5846
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH KLU_TpetraDeprecation
TRILINOS_SOURCE_REPO https://github.com/brian-kelley/Trilinos
TRILINOS_SOURCE_SHA 843c5b3
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 56b3183


CDash Test Results for PR# 5846.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 23e4193 into trilinos:develop Sep 3, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 5846: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Sep 3, 2019
@trilinos-autotester trilinos-autotester mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

@tjfulle tjfulle Awaiting requested review from tjfulle

@kddevin kddevin Awaiting requested review from kddevin

Assignees
No one assigned
Labels
impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) pkg: Amesos2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brian-kelley @trilinos-autotester @mhoemmen