-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trilinos: Deprecate four packages (second attempt) #4957
Conversation
@kddevin, if you don't mind, can i rebase this branch on top of 'develop' and run a local build? |
@bartlettroscoe |
@bartlettroscoe |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kddevin, thanks for testing the ATDM Trilinos configuration to verify it works. This should be okay to merge now.
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe mhoemmen ]! |
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
Merge on Pull Request# 4957: IS A SUCCESS - Pull Request successfully merged |
…s:develop' (429b3db). * trilinos-develop: (38 commits) stk snapshot as of 10/21/2019 Ifpack2: Adding Richardson support to Ifpack2::Relaxation PullRequestLinuxDriver.sh: remove ".sandia.gov" from the no_proxy environemt variable MueLu: Stuff for running w/o a pre-smoother Removing dependence on optipack (better guards; removed XML ) trilinos#4957 Clean up handling of compiler parsing matching (trilinos#6124) ATDM: Disable ROL tests that don't work with CUDA (trilinos#6124) ATDM: Move broad disables of individual tests to the ATDMDisables.cmake file ATDM: Remove unused files after switching to waterman/tweaks/Tweaks.cmake SQUASH AGAINST: ATDM: Add support for a single <system_name>/tweaks/Tweaks.cmake file ATDM: Disable two Intrepid2 tests for gnu+openmp+debug build (trilinos#6020) ATDM: Disable several Tempus tests in all waterman debug builds (trilinos#6009) ATDM: Switch to usage of Tweaks.cmake file for 'ride' builds ATDM: Disable several Tempus tests in all waterman debug builds (trilinos#6009) SEACAS: Allow for disable of explore exe (trilinos#6008) ATDM: Disable SEACAS explore build on cuda+rdc builds (trilinos#6008) ATDM: Switch to use of Tweaks.cmake file for waterman builds ATDM: Add support for a single <system_name>/tweaks/Tweaks.cmake file Tempus: Cleanup some warnings. rythmos: fixed printing of Teuchos::SerialDense* to remove deprecated behavior. Following pattern in trilinos#5374. ...
…s:develop' (429b3db). * trilinos-develop: (38 commits) stk snapshot as of 10/21/2019 Ifpack2: Adding Richardson support to Ifpack2::Relaxation PullRequestLinuxDriver.sh: remove ".sandia.gov" from the no_proxy environemt variable MueLu: Stuff for running w/o a pre-smoother Removing dependence on optipack (better guards; removed XML ) trilinos#4957 Clean up handling of compiler parsing matching (trilinos#6124) ATDM: Disable ROL tests that don't work with CUDA (trilinos#6124) ATDM: Move broad disables of individual tests to the ATDMDisables.cmake file ATDM: Remove unused files after switching to waterman/tweaks/Tweaks.cmake SQUASH AGAINST: ATDM: Add support for a single <system_name>/tweaks/Tweaks.cmake file ATDM: Disable two Intrepid2 tests for gnu+openmp+debug build (trilinos#6020) ATDM: Disable several Tempus tests in all waterman debug builds (trilinos#6009) ATDM: Switch to usage of Tweaks.cmake file for 'ride' builds ATDM: Disable several Tempus tests in all waterman debug builds (trilinos#6009) SEACAS: Allow for disable of explore exe (trilinos#6008) ATDM: Disable SEACAS explore build on cuda+rdc builds (trilinos#6008) ATDM: Switch to use of Tweaks.cmake file for waterman builds ATDM: Add support for a single <system_name>/tweaks/Tweaks.cmake file Tempus: Cleanup some warnings. rythmos: fixed printing of Teuchos::SerialDense* to remove deprecated behavior. Following pattern in trilinos#5374. ...
@trilinos/piro @trilinos/optipack @trilinos/claps @trilinos/globipack @trilinos/framework
Description
Second attempt at deprecating Trios, Claps, OptiPack, GlobiPack.
First attempt caused issues that were not caught in PR testing.
First attempt caused problems for Albany and ATDM. #4904
Added more guards in Piro for OptiPack content.
See #4864 for details
Motivation and Context
See #4864
Related Issues
How Has This Been Tested?
Used ATDM testing instructions in #4904
On Linux workstation (three cases):
Standard ATDM configuration for Piro:
ATDM with Piro and OptiPack enabled (verified that deprecation warnings are produced):
Claps test (verified that deprecation warnings are produced)
I could not get Trios to compile, and I can not find evidence that anyone else does, either.