-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trilinos: Deprecate four packages OptiPack, GlobiPack, Trios, Claps #4864
Conversation
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
External users would never notice these warnings. To really get their attention, one should deprecate the header files as well:
Personally I think deprecating and removing GlobiPack and OptiPack is low priority because these are small packages developed with TDD from the very beginning with extremely high unit test coverage. If nothing else, they serve as examples of numerical software with very strong unit tests and strong verification tests. Check out the verification tests for Nonlinear CG in OptiPack.
AS for GlobiPack, I wish we had put some effort into standardizing on globalization methods instead of just rewriting them from scratch all the time. They deserve high-quality reusable implementations.
@bartlettroscoe and @rppawlo thanks for reviewing this PR. @bartlettroscoe I did follow the instructions you cited; thanks. By putting the deprecation warning in OptiPack_Config.h.in and GlobiPack_Config.h.in , they will be included in OptiPack_Config.h and GlobiPack_Config.h, which should be (and, indeed, appear to be) included in all headers. I understand that deprecating these isn't the highest priority, but they were easy to do while deprecating the other packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding deprecated warnings to the headers.
NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester... |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 3204 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 3033 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 1480 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 1212 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 895 (click to expand)
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 3212 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 3041 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 1488 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 1220 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 903 (click to expand)
|
The testing here seems to have failed to launch due to a Jenkins error. I will report this to see and see if I can get it running again. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 3221 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 3050 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 1497 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 1229 (click to expand)
Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 912 (click to expand)
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: kddevin |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]! |
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
Merge on Pull Request# 4864: IS A SUCCESS - Pull Request successfully merged |
…s:develop' (7db7806). * trilinos-develop: (54 commits) MueLu: Missed some FE MueLu: Missed some FE Added header deprecation warning avoidance for Globipack and Optipack Package deprecation: trilinos#4864 Implemented scheme for eliminating headerfile deprecation warnings when -Werror is set. Defined -DTRILINOS_HIDE_DEPRECATED_HEADER_WARNINGS in PR testing only for Piro, since it is the only package that enables the deprecated packages. Packages Trios and Claps are not tested in PR testing. MueLu: Adding FE helper macro; removing ambiguity in RefMaxwell (special thanks to Ed Love) MiniEM: Do not run with Epetra and MueLu's Kokkos Refactor Tpetra: Fix build warning (unused typedef) in BMV2 test Tpetra: Fix build warning (unused typedef) in matrix-matrix multiply Tpetra: Add unit test for aliased deep_copy of MultiVectors Tpetra: Fix the fix for trilinos#4827 (address aliasing) Tpetra: Get more tests to pass with CUDA_LAUNCH_BLOCKING unset Tpetra: Fix copyConvert Tpetra: Fix copyConvert for Sacado PCE types Tpetra: Make Map follow C.21 Tpetra: Make FEMultiVector follow C.21; clean up class Tpetra: Make FECrsGraph & FECrsMatrix follow C.21 Tpetra: Make CrsGraph & CrsMatrix follow C.21 Tpetra: Make DistObject, MultiVector, & Vector follow C.21 Tpetra::MultiVector: Improve assign & deep_copy Tpetra::MultiVector: Fix trilinos#4827 (copyConvert); simplify localDeepCopy ...
…rilinos#4904, trilinos#4864) This fixes logic added in PR trilinos#4864 for when OptiPack is not even enabled.
…s' into atdm-nightly (#4864, #4904, #4908) The changes in PR #4964 breaks all of the ATDM Trilinos builds so it is urgent to revert this branch. See #4904. Becuase of big backups and random failures in the Trilinos PR builds, there is no guarantee that the auto-tester will merge the revert PR #4908 before tonight at 10 PM MDT when the 'atdm-nightly' branch gets updated. Therefore, it is important to make sure this gets in. This has set back getting SPARC Trilinos Integration testing another day.
…s:develop' (7db7806). * trilinos-develop: (71 commits) Tpetra: Style change on GlobalOrdinals CMake error messages Tpetra: Fixing global ordinals defaults Use Multiple Issue Templates (trilinos#4879) Tpetra,Teuchos: Fix trilinos#2567; Fix trilinos#1183 tpetra Removed unrelated compiler warning to allow PR testing to pass clean_workspace.py: move from atdm module for ninja to sems module Revert "Trilinos: Deprecate four packages OptiPack, GlobiPack, Trios, Claps" MueLu: split library into two MueLu: disable useless cmake commands MueLu: clean up script used in ETI xpetra: fixed compilation errors from bad merge Exclude 'ride14' from running pure 'debug' builds (ATDV-159) MueLu: Missed some FE MueLu: Missed some FE MueLu: Generalizing MueLu::TpetraOperator to work with Operators, not just Hierarchies (for RefMaxwell) Xpetra: remove unused variable Added header deprecation warning avoidance for Globipack and Optipack Package deprecation: trilinos#4864 Implemented scheme for eliminating headerfile deprecation warnings when -Werror is set. Defined -DTRILINOS_HIDE_DEPRECATED_HEADER_WARNINGS in PR testing only for Piro, since it is the only package that enables the deprecated packages. Packages Trios and Claps are not tested in PR testing. MueLu: Adding FE helper macro; removing ambiguity in RefMaxwell (special thanks to Ed Love) tpetra: Change needed after merge with develop ...
…_optipack_globipack Automatically Merged using Trilinos Pull Request AutoTester PR Title: OptiPack and GlobiPack: Removing deprecated packages #4864 PR Author: kddevin
…_claps Automatically Merged using Trilinos Pull Request AutoTester PR Title: Claps: removing deprecated package claps #4864 PR Author: kddevin
…s:develop' (214786e). * trilinos-develop: MueLu: removing temporarily faulty work in ParameterListInterpreter until we can figure out a better to test for multi-rank output. Fix remove Piro::PerformAnalysis Update Piro_PerformAnalysis.cpp Piro: remove code related to Moocho, OptiPack and GlobiPack Piro: Enable full-space optimization using ROL SimOpt interface Modify/add tests to test new interface ROL: adding Thyra Adapters for Constraint and Objective SimOpt classes Piro: Modifications to Piro::NoxSolver to avoid recomputing the state during optimization MueLu: adding elasticity test for coarse AMG solve in region MG OptiPack and GlobiPack: Removing deprecated packages trilinos#4864 MueLu: adding logic for region to composite coordinates in the case of Elasticity Claps: removing deprecated package claps trilinos#4864 MueLu: modifying some xml files and adding test MueLu: modifying the amg_1dof.xml file since coordinates have been turned on MueLu: extracting coarse coordinates from region hierarchy to create AMG coarse solver
…s:develop' (214786e). * trilinos-develop: MueLu: removing temporarily faulty work in ParameterListInterpreter until we can figure out a better to test for multi-rank output. Fix remove Piro::PerformAnalysis Update Piro_PerformAnalysis.cpp Piro: remove code related to Moocho, OptiPack and GlobiPack Piro: Enable full-space optimization using ROL SimOpt interface Modify/add tests to test new interface ROL: adding Thyra Adapters for Constraint and Objective SimOpt classes Piro: Modifications to Piro::NoxSolver to avoid recomputing the state during optimization MueLu: adding elasticity test for coarse AMG solve in region MG OptiPack and GlobiPack: Removing deprecated packages trilinos#4864 MueLu: adding logic for region to composite coordinates in the case of Elasticity Claps: removing deprecated package claps trilinos#4864 MueLu: modifying some xml files and adding test MueLu: modifying the amg_1dof.xml file since coordinates have been turned on MueLu: extracting coarse coordinates from region hierarchy to create AMG coarse solver
…_trios Automatically Merged using Trilinos Pull Request AutoTester PR Title: Trios: Removing deprecated package trios #4864 PR Author: kddevin
When the Claps package was removed in trilinos#4864, it actually broke the usage of the checkin-test-sems.sh script for people that were using that script. That is because the file local-checkin-test-defaults.py was already written that had Claps listed in --disabled-packages in that file. This broke the sync of ROL for a while to their subproject repo. Given the current Trilinos GitHub PR testing system and the reduced usage of the checkin-test.py script, there is no longer a need for adding an argument like --disabled-packages to list out packages like PyTrilinos or TriKota. These were listed many years ago so thaty if someone had edits in one of these packages, then it would bascially bring their build down because packages like PyTrilinos and TriKota would almost never be able to build. But since then I updated the checkin-test.py script to filter out any EX or even ST packages from --default-bulds, edited packages like these did not get enabled anyway. These are ST packages so they would get enabled in --st-extra-builds=<buildname0>,... but if someone were modifying these packages then they better be testing them. So I can't see any reason to be listed any packages by default in --disabled-packages. So removing the --disabled-packages argument from this generated file should eliminate a future source of breakage like happened with the removal of Claps.
@kddevin Tracking down an "unused variable" warning through spack, it looks like this pull request removed the optional external repository package |
@trilinos/optipack @trilinos/globipack @trilinos/trios @trilinos/claps @trilinos/framework
Description
The following four packages are scheduled for deprecation and removal from the Trilinos repository:
The packages will be deprecated in mid-April 2019, and will be removed from the Trilinos develop and master branches in mid-May 2019.
This PR adds deprecation warnings.
Motivation and Context
Reducing cost of Trilinos maintenance by removing unused / obsolete packages.
How Has This Been Tested?
For Claps, OptiPack, GlobiPack:
cmake
-D Trilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON
-D CMAKE_BUILD_TYPE:STRING=DEBUG
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF
-D MPI_BASE_DIR:PATH=/Users/InstalledSoftware/openmpi-1.8.3
-D TPL_ENABLE_MPI:BOOL=ON
-D Trilinos_ENABLE_Fortran:BOOL=OFF
-D Trilinos_ENABLE_ALL_PACKAGES:BOOL=OFF
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON
-D Trilinos_ENABLE_EXAMPLES:BOOL=OFF
-D Trilinos_ENABLE_TESTS:BOOL=OFF
-D Trilinos_VERBOSE_CONFIGURE:BOOL=OFF
-D Trilinos_ENABLE_GlobiPack:BOOL=ON
-D Trilinos_ENABLE_OptiPack:BOOL=ON
-D Trilinos_ENABLE_Piro:BOOL=ON
-D Piro_ENABLE_OptiPack:BOOL=ON
-D Piro_ENABLE_ROL:BOOL=OFF
-D Trilinos_ENABLE_ROL:BOOL=OFF
-D Trilinos_ENABLE_MOOCHO:BOOL=OFF
-D Trilinos_ENABLE_Tempus:BOOL=OFF
-D Trilinos_ENABLE_Stokhos:BOOL=OFF
-D Trilinos_ENABLE_Rythmos:BOOL=OFF
-D Trilinos_ENABLE_MueLu:BOOL=OFF
-D Trilinos_ENABLE_Ifpack2:BOOL=OFF
-D Trilinos_ENABLE_NOX:BOOL=OFF
-D NOX_ENABLE_Epetra:BOOL=ON
-D Trilinos_ENABLE_Tpetra:BOOL=ON
-D Tpetra_INST_INT_INT:BOOL=ON
-D Tpetra_INST_INT_LONG_LONG:BOOL=OFF
-D Trilinos_ENABLE_TriKota:BOOL=OFF
-D Piro_ENABLE_TESTS=ON
-D Piro_ENABLE_EXAMPLES=ON
-D OptiPack_HIDE_DEPRECATED_CODE=ON
-D Trilinos_ENABLE_Claps:BOOL=ON
-D Claps_ENABLE_EXAMPLES:BOOL=ON
-D Claps_ENABLE_TESTS:BOOL=ON
-D TPL_ENABLE_METIS:BOOL=ON
-D METIS_LIBRARY_DIRS:FILEPATH="/Users/InstalledSoftware/ParMETIS_4.0.3/32bit"
-D METIS_INCLUDE_DIRS:FILEPATH="/Users/InstalledSoftware/ParMETIS_4.0.3/32bit"
-D Teuchos_ENABLE_STACKTRACE=OFF
..
Trios builds did not succeed on my platform, but the deprecation warnings were correctly emitted. The build errors did not appear to be related to these changes.
cmake
-D Trilinos_ENABLE_EXPLICIT_INSTANTIATION:BOOL=ON
-D CMAKE_BUILD_TYPE:STRING=DEBUG
-D CMAKE_VERBOSE_MAKEFILE:BOOL=OFF
-D MPI_BASE_DIR:PATH=/Users/InstalledSoftware/openmpi-1.8.3
-D TPL_ENABLE_MPI:BOOL=ON
-D Trilinos_ENABLE_Fortran:BOOL=OFF
-D Trilinos_ENABLE_ALL_PACKAGES:BOOL=OFF
-D Trilinos_ENABLE_ALL_OPTIONAL_PACKAGES:BOOL=ON
-D Trilinos_ENABLE_EXAMPLES:BOOL=OFF
-D Trilinos_ENABLE_TESTS:BOOL=OFF
-D Trilinos_VERBOSE_CONFIGURE:BOOL=OFF
-D Trilinos_ENABLE_GlobiPack:BOOL=ON
-D Trilinos_ENABLE_OptiPack:BOOL=ON
-D Trilinos_ENABLE_Trios:BOOL=ON
-D Trilinos_ENABLE_Triossupport=ON
-D Trilinos_ENABLE_Triostests=ON
-D Trilinos_ENABLE_Triosprograms=ON
-D Trilinos_ENABLE_Triosexamples=ON
-D Trilinos_ENABLE_Triosnnti=ON
-D Trilinos_ENABLE_Triosnssi=ON
-D Teuchos_ENABLE_STACKTRACE=OFF
.
Checklist