Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: fixing CoordinateTransferFactory_kokkos for structured aggregation #4452

Merged
merged 1 commit into from
Feb 21, 2019
Merged

MueLu: fixing CoordinateTransferFactory_kokkos for structured aggregation #4452

merged 1 commit into from
Feb 21, 2019

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Feb 20, 2019

@trilinos/muelu

Description

This adds logic in the CoordinateTransferFactory_kokkos to allow user to perform structured aggregation and hand-off the aggregates to tentative P factory.
Also added xmls and tribits test to check that it all works fine.

Motivation and Context

This is mainly adding test coverage which is a good thing?

How Has This Been Tested?

I ran the tests locally and they passed

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@lucbv
MueLu: fixing CoordinateTransferFactory_kokkos for structured aggrega…
f793a80 
…tion

This adds logic in the CoordinateTransferFactory_kokkos to allow user to perform structured aggregation and hand-off the aggregates to tentative P factory.
Also added xmls and tribits test to check that it all works fine.
@lucbv lucbv added type: enhancement Issue is an enhancement, not a bug pkg: MueLu AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Feb 20, 2019
@lucbv lucbv self-assigned this Feb 20, 2019
@lucbv lucbv requested a review from a team as a code owner February 20, 2019 23:55
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job Trilinos_pullrequest_gcc_4.8.4 to start: Total Wait = 603

  • Other jobs have been previously started - We must stop them...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2600
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2397
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 889
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 553
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 315
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Using Repos:

Repo: TRILINOS (lucbv/Trilinos)
  • Branch: MueLu_structured_tentative_kokkos
  • SHA: f793a80
  • Mode: TEST_REPO

Pull Request Author: lucbv

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2600
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2397
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 889
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 553
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 315
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4452
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH MueLu_structured_tentative_kokkos
TRILINOS_SOURCE_REPO https://github.com/lucbv/Trilinos
TRILINOS_SOURCE_SHA f793a80
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA d7d9b5a


CDash Test Results for PR# 4452.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ cgcgcg ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 2abf1dd into trilinos:develop Feb 21, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 4452: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Feb 21, 2019
@lucbv lucbv deleted the MueLu_structured_tentative_kokkos branch February 21, 2019 15:59
@lucbv lucbv mentioned this pull request Mar 4, 2019
Merged
5 tasks
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgcgcg cgcgcg cgcgcg approved these changes

@csiefer2 csiefer2 Awaiting requested review from csiefer2

@rstumin rstumin Awaiting requested review from rstumin

@jhux2 jhux2 Awaiting requested review from jhux2

@mayrmt mayrmt Awaiting requested review from mayrmt

Assignees

@lucbv lucbv

Labels
pkg: MueLu type: enhancement Issue is an enhancement, not a bug
Projects
MueLu
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucbv @trilinos-autotester @cgcgcg