Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on Werror for EpetraExt, Pike, & Zoltan2 #4450

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Turn on Werror for EpetraExt, Pike, & Zoltan2 #4450

merged 1 commit into from
Feb 21, 2019

Conversation

ZUUL42
Copy link
Contributor

@ZUUL42 ZUUL42 commented Feb 20, 2019 •
edited
Loading

@trilinos/framework

Description

This will turn on Warnings as Errors for the @trilinos/epetraext , @trilinos/pike, & @trilinos/zoltan2 packages. It also reformats the flags for a bit cleaner code, sets the warning flags for all packages, and prepares to turn Werror on for all packages individually until they can be turned on for all.

Motivation and Context

This addresses issue #3178

How Has This Been Tested?

This has successfully been test built: results

Checklist

  • My commit messages mention the appropriate GitHub issue numbers.
  • My code follows the code style of the affected package(s).
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the code contribution guidelines for this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • No new compiler warnings were introduced.
  • These changes break backwards compatibility.

@ZUUL42 ZUUL42 self-assigned this Feb 20, 2019
@ZUUL42 ZUUL42 added Framework tasks Framework tasks (used internally by Framework team) AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Framework Issues that fall under the Trilinos Framework Product Area labels Feb 20, 2019
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2596
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2393
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 885
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 548
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 311
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Using Repos:

Repo: TRILINOS (ZUUL42/Trilinos)
  • Branch: Werror
  • SHA: 2030b77
  • Mode: TEST_REPO

Pull Request Author: ZUUL42

@mhoemmen
Copy link
Contributor

Pike doesn't have a GitHub group; should we make one?

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 2596
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 2393
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL

  • Build Num: 885
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0

  • Build Num: 548
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb

Build Information

Test Name: Trilinos_pullrequest_cuda_9.2

  • Build Num: 311
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
JENKINS_JOB_TYPE Experimental
PULLREQUESTNUM 4450
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH Werror
TRILINOS_SOURCE_REPO https://github.com/ZUUL42/Trilinos
TRILINOS_SOURCE_SHA 2030b77
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10b39bb


CDash Test Results for PR# 4450.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

mhoemmen
mhoemmen approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 59dcf58 into trilinos:develop Feb 21, 2019
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 4450: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Feb 21, 2019
@trilinos-autotester trilinos-autotester mentioned this pull request Apr 6, 2020
Merged
@trilinos-autotester trilinos-autotester mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhoemmen mhoemmen mhoemmen approved these changes

@prwolfe prwolfe Awaiting requested review from prwolfe

@jwillenbring jwillenbring Awaiting requested review from jwillenbring

@william76 william76 Awaiting requested review from william76

Assignees

@ZUUL42 ZUUL42

Labels
Framework tasks Framework tasks (used internally by Framework team) PA: Framework Issues that fall under the Trilinos Framework Product Area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZUUL42 @trilinos-autotester @mhoemmen