Panzer: allow HVol elements #3917
Conversation
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
@egphill Looks good to me!. But why do we need to keep the const basis? It's a bit confusing to me. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: egphill |
|
@mperego I want to keep Const for backward compatibility first of all. But in general, it might be useful. It's a piecewise constant basis that isn't scaled by the volume of the cell, so the basis is just one on every element. |
|
I see. |
| @@ -0,0 +1,1741 @@ | |||
| (* Content-type: application/vnd.wolfram.mathematica *) | |||
There was a problem hiding this comment.
did you mean to commit this file?
There was a problem hiding this comment.
I can remove this file.
There was a problem hiding this comment.
Ok, I removed it. This needs to be re-approved.
|
@mperego Now that we have HVol, we should be using it how you say. Historically, application codes have used Const for curls of HCurl fields in 2D, and it's been working at lowest order. |
|
@rppawlo I did not add an HVol projection test. Would you like me to? |
|
If it's quick, we probably should. I have a 2D projection test sitting on a branch so we could wait until that is merged in and add it there. If you wan to push now that's fine too. |
|
@rppawlo Is the 2D projection test you're talking about a 2D version of the ToNodal test in the L2Projection tests? If so, I think it'd be easiest just to include the HVol test there. |
yes. I'll get that pushed next week and add it there. |
…oth HCurl and HDiv elements in 3D or HCurl and HVol elements in 2D. Exposed HVol basis type and defined its basis values. Modified L2Projection to allow HVol elements. Removed Mathematica file
egphill
force-pushed
the
add-2d-hvol-elements-to-panzer
branch
from
4fa2e7e to
bf5b85c
Compare
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 1693 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3 # 2258 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 1919 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 230 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
mperego
added
the
AT: AUTOMERGE
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Using Repos:
Pull Request Author: egphill |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mperego rppawlo ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 3917: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
Adapted CurlLaplacianExample into a mixed version that uses both HCurl and HDiv elements in 3D or HCurl and HVol elements in 2D.
Exposed HVol basis type and defined its basis values. Modified L2Projection to allow HVol elements.
@trilinos/
Description
Previously HVol elements were allowed in Panzer only through the Const basis option. This was restricted to zeroth order and did not use the HVOL basis value transformation for defining the basis. This change keeps the Const basis but adds the option to use arbitrary order HVol elements on 2D meshes.
Motivation and Context
The z component of an HDiv DOF should use an HVol basis in 2D. This is necessary for arbitrary order electromagnetics in 2D.
How Has This Been Tested?
Added the test example MixedCurlLaplacianExample. This is the same test as CurlLaplacianExample except it's in mixed form such that it uses both HCurl elements for the primary DOF and HVol elements for the curl of that DOF.
Checklist
Most everything in the MixedCurlLaplacianExample directory is copied directly from CurlLaplacianExample. The changes of interest there are in Example_CurlLaplacianEquationSet_impl.hpp, main.cpp, and CMakeLists.txt.