Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teuchos: remove latent checks for long long #2591

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Conversation

ibaned
Copy link
Contributor

@ibaned ibaned commented Apr 19, 2018

@trilinos/teuchos

Description

I missed a few #ifdefs for long long, which caused nightly tests to fail if they were turning long long off in their CMake configuration.

Motivation and Context

See #2589

@ibaned ibaned added the pkg: Teuchos Issues primarily dealing with the Teuchos Package label Apr 19, 2018
@ibaned ibaned self-assigned this Apr 19, 2018
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

Should we just grep all of Trilinos looking for HAVE_TEUCHOS_LONG_LONG_INT and remove all of these ifdefs?

@ibaned
Copy link
Contributor Author

ibaned commented Apr 19, 2018

@bartlettroscoe yes, we should. Once thats done then the CMake option can be fully removed.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 515
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2591
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH no-long-long-fix
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA c914344
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9a025d7

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 232
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2591
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH no-long-long-fix
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA c914344
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9a025d7

Using Repos:

Repo: TRILINOS (trilinos/Trilinos)
  • Branch: no-long-long-fix
  • SHA: c914344
  • Mode: TEST_REPO

Pull Request Author: ibaned

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_4.9.3

  • Build Num: 515
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.9.3
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2591
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH no-long-long-fix
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA c914344
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9a025d7

Build Information

Test Name: Trilinos_pullrequest_gcc_4.8.4

  • Build Num: 232
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
COMPILER_MODULE sems-gcc/4.8.4
JENKINS_BUILD_TYPE Release
JENKINS_COMM_TYPE MPI
JENKINS_DO_COMPLEX OFF
JENKINS_JOB_TYPE Experimental
MPI_MODULE sems-openmpi/1.8.7
PULLREQUESTNUM 2591
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH no-long-long-fix
TRILINOS_SOURCE_REPO https://github.com/trilinos/Trilinos
TRILINOS_SOURCE_SHA c914344
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 9a025d7


CDash Test Results for PR# 2591.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file)

@ibaned ibaned merged commit 0b2f9d8 into develop Apr 19, 2018
@ibaned ibaned deleted the no-long-long-fix branch April 19, 2018 21:10
Copy link
Contributor

@mhoemmen mhoemmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ibaned ! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants