Patch SuperLU_Dist interface for version 5.0 #246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2016 16:35
SuperLU_Dist 5.0 broke backwards compatability by renaming several structs. I do a configure-time check to see which struct name should be used. When Sherry Li introduces version numbers, this will be unnecessary. The structs are then protected by #ifdef statements in the Amesos2 interface. See issue #245.
SuperLU_Dist 5.0 broke backwards compatability by renaming several structs. I do a configure-time check to see which struct name should be used. When Sherry Li introduces version numbers, this will be unnecessary. The structs are then protected by #ifdef statements in the Amesos interface. See issue #245.
|
@BarrySmith @jwillenbring @jdbooth @srajama1 @trilinos/amesos2 Referencing the appropriate parties... |
|
I assigned Siva to this pull request. Feel free to delegate as necessary. |
|
Alicia : I am on vacation and won't have time to get to this quickly. Can you make sure checkin tests pass (or muelu tests pass, which will ensure the primary user of Amesos2 will work) and commit it. Also adding @jdbooth to see if he can help. Please coordinate among you and Josh. |
|
I will take a look at the pull request tonight and test. |
bartlettroscoe
added a commit
that referenced
this pull request
Dec 21, 2016
It turns out that if you have some SEMS modules loaded manaully before sourcing load_sems_dev_env.sh, then some module loads will fail and the user will not have the right env. That can lead to bad pre-push CI testing (see Therefore, to make these scripts more robust, now a 'module purge' is done unconditionally. Given the structure of the SEMS modules, I don't see a robust way to avoid doing a 'module purge'. But note that one can just open a new shell and then source this to be safe. The unload_sems_dev_env.sh also does an unconditional 'module purge' and wipes out the var TRILINOS_SEMS_DEV_ENV_LOADED. I also added the module sems-git/2.10.1 so as to make the checkin-test-sems.sh script work more robustly.
bartlettroscoe
added a commit
to bartlettroscoe/Trilinos
that referenced
this pull request
Jan 5, 2018
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = [email protected]:TriBITSPub/TriBITS.git' At commit: commit c5d3fc9b4620cfd8d2e938ea4d9ca9d974b386f3 Author: Roscoe A. Bartlett <[email protected]> Date: Wed Dec 20 16:03:01 2017 -0700 Summary: Merge pull request trilinos#246 from dalg24/fix_typo_developers_guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This almost certainly breaks the Doxygen for these interfaces.