Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change C standard of SIERRA builds of Trilinos from c99 to c11 #1974

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Change C standard of SIERRA builds of Trilinos from c99 to c11 #1974

merged 1 commit into from
Nov 13, 2017

Conversation

prwolfe
Copy link
Contributor

@prwolfe prwolfe commented Nov 8, 2017

This file should be merged to Trilinos only after
pull request #239 in TriBITSPub has been propigated
to Trilinos. (TriBITSPub/TriBITS#239)
It merely sets the override for the sierra builds to
be the c11 posix standard.

@prwolfe
create a way to pass in the c standard via tribits.
ab8044a 
This file should be merged to Trilinos only after
pull request trilinos#239 in TriBITSPub has been propigated
to Trilinos. (TriBITSPub/TriBITS#239)
It merely sets the override for the sierra builds to
be the c11 posix standard.
@prwolfe prwolfe self-assigned this Nov 8, 2017
@bartlettroscoe bartlettroscoe added the stage: in progress Work on the issue has started label Nov 8, 2017
@prwolfe prwolfe mentioned this pull request Nov 8, 2017
Closed
bartlettroscoe added a commit to TriBITSPub/TriBITS that referenced this pull request Nov 10, 2017
@bartlettroscoe
Merge branch 'add_c_standard_input_flag' (#239)
fd1f66e 
This is needed for trilinos/Trilinos#1974.

Build/Test Cases Summary
Enabled Packages:
Enabled all Packages
0) MPI_DEBUG => passed: passed=263,notpassed=0 (0.74 min)
1) SERIAL_RELEASE => passed: passed=263,notpassed=0 (0.62 min)
2) MPI_DEBUG_CMAKE-3.6.2 => passed: passed=284,notpassed=0 (0.62 min)
3) SERIAL_RELEASE_CMAKE-3.6.2 => passed: passed=284,notpassed=0 (0.53 min)
Other local commits for this build/test group: 6e3d7d2, f22a20e, 09cc5c4
@bartlettroscoe
Copy link
Member

@prwolfe,

I merged the branch from TriBITSPub/TriBITS#239. I am in the process if pushing the updated TriBITS snapshot into Trilinos (as per the process given in http://trac.trilinos.org/wiki/TriBITSTrilinosDev). After that snapshot is merged, we could merge this PR. However, does Trilinos C code build clean with --std=c11? If not, we may need to set up an Experimental build of Trilinos posting to CDash and then get Trilinos developers to clean up their C code to build clean with --std=c11.

bartlettroscoe added a commit that referenced this pull request Nov 10, 2017
@bartlettroscoe
Merge branch 'tribits_github_snapshot' into develop (#1974)
a4fec9d 
Allows override of --std=<cstd> for compiling C files (TriBITSPub/TriBITS#239)

Build/Test Cases Summary
Enabled Packages:
Disabled Packages: PyTrilinos,Claps,TriKota
Enabled all Packages
0) MPI_RELEASE_DEBUG_SHARED_PT => passed: passed=2501,notpassed=0 (105.92 min)
Other local commits for this build/test group: e8ab9eb
@bartlettroscoe
Copy link
Member

bartlettroscoe commented Nov 10, 2017 •
edited
Loading

FYI: TriBITS has been updated in Trilinos in commit a4fec9d to support the new Trilinos_C_Standard option which is documented at:

At this point, the @trilinos/framework team will need to decide how to proceed.

@bartlettroscoe
Copy link
Member

Okay, since this PR branch is not changing the default C standard for all Trilinos builds, just the SIERRA builds of Trilinos, I guess as long as that works, then this can be merged right away.

Since the ability to change the C standard was already taken care of in commit a4fec9d, this PR should be called "Change C standard of SIERRA builds of Trilinos from c99 to c11". I will change the title to reflect that.

@bartlettroscoe bartlettroscoe changed the title create a way to pass in the c standard via tribits. Change C standard of SIERRA builds of Trilinos from c99 to c11 Nov 10, 2017
bartlettroscoe
bartlettroscoe approved these changes Nov 10, 2017
View reviewed changes
Copy link
Member

@bartlettroscoe bartlettroscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this only impacts the SIERRA builds of Trilinos and does not change the default, I don't see any reason why this should not be merged in to 'develop'

@prwolfe prwolfe merged commit 05971c2 into trilinos:develop Nov 13, 2017
@bartlettroscoe bartlettroscoe removed the stage: in progress Work on the issue has started label Nov 13, 2017
@prwolfe prwolfe mentioned this pull request Nov 13, 2017
Closed
2 tasks
@prwolfe prwolfe deleted the add_c_standard_input_flag branch November 21, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartlettroscoe bartlettroscoe bartlettroscoe approved these changes

@bmpersc bmpersc Awaiting requested review from bmpersc

Assignees

@prwolfe prwolfe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prwolfe @bartlettroscoe