Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IOSS: Fix shadow variable in region #13438

Merged
merged 1 commit into from
Sep 10, 2024
Merged

IOSS: Fix shadow variable in region #13438

merged 1 commit into from
Sep 10, 2024

Conversation

gsjaardema
Copy link
Contributor

@gsjaardema gsjaardema commented Sep 9, 2024 •
edited
Loading

@trilinos/seacas

Motivation

Remove shadow variable added during topology modification merge.

Related Issues

Stakeholder Feedback

Testing

@gsjaardema gsjaardema added pkg: seacas AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Data Services Issues that fall under the Trilinos Data Services Product Area client: Albany Issue impacting the Albany project labels Sep 9, 2024
@gsjaardema gsjaardema requested a review from ikalash September 9, 2024 22:24
@gsjaardema gsjaardema self-assigned this Sep 9, 2024
@gsjaardema gsjaardema requested a review from a team as a code owner September 9, 2024 22:24
@gsjaardema gsjaardema requested a review from rppawlo September 9, 2024 22:26
@gsjaardema
Copy link
Contributor Author

This change has bee backported to SEACAS github so should not reappear in next snapshot.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 495
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_gcc

  • Build Num: 545
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 546
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_clang

  • Build Num: 544
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4503
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_cuda

  • Build Num: 543
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_intel

  • Build Num: 464
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 543
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Using Repos:

Repo: TRILINOS (gsjaardema/Trilinos)
  • Branch: SEACAS-fix-shadow-variable-2
  • SHA: 2ae26f6
  • Mode: TEST_REPO

Pull Request Author: gsjaardema

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: PR_gcc-openmpi-openmp

  • Build Num: 495
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_gcc

  • Build Num: 545
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_gcc-openmpi_debug

  • Build Num: 546
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-gnu-8.5.0-openmpi-4.1.6-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_clang

  • Build Num: 544
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-clang-11.0.1-openmpi-4.0.5-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 4503
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
BLOCKING_BUILD false
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_aue-gnu-12.1.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_cuda

  • Build Num: 543
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8-gpu
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_intel

  • Build Num: 464
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-intel-2021.3-sems-openmpi-4.1.6_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685

Build Information

Test Name: PR_cuda-uvm

  • Build Num: 543
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel8_sems-cuda-11.4.2-gnu-10.1.0-openmpi-4.1.6_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: seacas;AT: RETEST;AT: AUTOMERGE;PA: Data Services;client: Albany
PULLREQUESTNUM 13438
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL rhel8
TRILINOS_SOURCE_REPO https://github.com/gsjaardema/Trilinos
TRILINOS_SOURCE_SHA 2ae26f6
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA 10d9685


CDash Test Results for PR# 13438.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Sep 10, 2024
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

ikalash
ikalash approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@ikalash ikalash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ ikalash ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit dbf8aaa into trilinos:develop Sep 10, 2024
15 of 20 checks passed
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 13438: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Sep 10, 2024
@gsjaardema gsjaardema deleted the SEACAS-fix-shadow-variable-2 branch September 10, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikalash ikalash ikalash approved these changes

@rppawlo rppawlo Awaiting requested review from rppawlo

Assignees

@gsjaardema gsjaardema

Labels
client: Albany Issue impacting the Albany project PA: Data Services Issues that fall under the Trilinos Data Services Product Area pkg: seacas
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsjaardema @trilinos-autotester @ikalash @gdsjaar