Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

belos: add missing parameter to getValidParameters in GmresPolySolMgr #10444

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

tmranse
Copy link
Contributor

@tmranse tmranse commented Apr 14, 2022

@trilinos/belos
@jennloe

Motivation

In trying to use the BelosGmresPolySolMgr object in Sierra/Aria, it was uncovered that the "Outer Solver Param" argument was not in the set of valid arguments provided. This was causing the object to throw when trying to give non-default outer solver parameters,

Stakeholder Feedback

Testing

Tested by running this change through the testing infrastructure.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

Copy link
Contributor

@hkthorn hkthorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job _cuda_10.1.243 to start: Total Wait = 603

@tmranse tmranse added AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Apr 20, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 7366
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 4862
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 5381
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 12416
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 5118
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: python-3

  • Build Num: 1679
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: _cuda_10.1.243

  • Build Num: 787
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Using Repos:

Repo: TRILINOS (tmranse/Trilinos)
  • Branch: belos_gmresPoly_param
  • SHA: 66c810f
  • Mode: TEST_REPO

Pull Request Author: tmranse

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_pullrequest_gcc_8.3.0

  • Build Num: 7366
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_serial

  • Build Num: 4862
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_gcc_7.2.0_debug

  • Build Num: 5381
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_intel_17.0.1

  • Build Num: 12416
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: Trilinos_pullrequest_clang_10.0.0

  • Build Num: 5118
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: python-3

  • Build Num: 1679
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0

Build Information

Test Name: _cuda_10.1.243

  • Build Num: 787
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
PR_LABELS pkg: Belos;AT: RETEST;AT: AUTOMERGE
PULLREQUESTNUM 10444
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_SOURCE_BRANCH belos_gmresPoly_param
TRILINOS_SOURCE_REPO https://github.com/tmranse/Trilinos
TRILINOS_SOURCE_SHA 66c810f
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA b09a0a0


CDash Test Results for PR# 10444.

@trilinos-autotester trilinos-autotester removed the AT: RETEST Causes the PR autotester to run a new round of PR tests on the next iteration label Apr 22, 2022
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jennloe hkthorn ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit 639b61a into trilinos:develop Apr 22, 2022
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 10444: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Apr 22, 2022
@tmranse tmranse deleted the belos_gmresPoly_param branch April 22, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants