Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build stat wrapper tests #9401

Open
jwillenbring opened this issue Jul 7, 2021 · 2 comments
Open

Build stat wrapper tests #9401

jwillenbring opened this issue Jul 7, 2021 · 2 comments
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. type: enhancement Issue is an enhancement, not a bug

Comments

@jwillenbring
Copy link
Member

Enhancement

@bartlettroscoe
@jjellio
CC: @e10harvey

When the PR for updating the build stat tool, #8638 was merged, it caused errors for downstream applications because of not being able to read an installation directory associated with the tool. That led to backing out a small part of the change in #9367. Would it be possible to add testing for the build stat tool that would protect against this kind of situation?

@jwillenbring jwillenbring added the type: enhancement Issue is an enhancement, not a bug label Jul 7, 2021
@bartlettroscoe
Copy link
Member

Would it be possible to add testing for the build stat tool that would protect against this kind of situation?

@jwillenbring just getting back from vacation. I think this is a pretty small issue that will be easy to fix. (I did not realize that APPs were pulling in CMAKE_AR from Trilinos.) The bigger concern for APPs is general installation testing for Trilinos (see #7383, #5027, #9234). That should be an order of magnitude a higher priority.

I will put in a fix to for this shortly.

@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jul 9, 2022
@bartlettroscoe bartlettroscoe added DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. and removed MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. labels Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

No branches or pull requests

2 participants