Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tpetra: non-blocking Import/Export #9251

Closed
tasmith4 opened this issue Jun 8, 2021 · 7 comments
Closed

Tpetra: non-blocking Import/Export #9251

tasmith4 opened this issue Jun 8, 2021 · 7 comments
Assignees
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: Tpetra type: enhancement Issue is an enhancement, not a bug

Comments

@tasmith4
Copy link
Contributor

tasmith4 commented Jun 8, 2021

Enhancement

@trilinos/tpetra

Provide an API for non-blocking imports and exports on DistObjects. The new API will have three general types of functions for both imports and exports. Using import as an example:

  • beginImport -- packs the data and initiates the asynchronous send
  • endImport -- waits for the asynchronous request to complete and unpacks the data
  • isImportReady -- check if the data is ready to unpack

@cgcgcg @vbrunini

@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jun 11, 2022
@tasmith4 tasmith4 added DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. and removed MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. labels Jun 13, 2022
@csiefer2
Copy link
Member

@tasmith4 Did you do everything you needed to here? Can I close this?

@tasmith4
Copy link
Contributor Author

Yes, that was done a while back. Looks like I tried to autoclose it in #10300, not sure why that didn't work ...

@GrahamBenHarper
Copy link
Contributor

@tasmith4 I noticed autocloses no longer work in Trilinos. I'm not sure what changed, but it's been this way for somewhere between months and a year

@ccober6
Copy link
Contributor

ccober6 commented May 30, 2023

@trilinos/framework @sebrowne Can you investigate why issues are not being auto closed and fix it? Thanks!

@sebrowne
Copy link
Contributor

I show that this has the DO_NOT_AUTOCLOSE label on it. Can you link any others that should have been closed but were not?

@tasmith4
Copy link
Contributor Author

@sebrowne I think we thought that DO_NOT_AUTOCLOSE would keep the bot from closing it, but would still allow it to be closed with keywords in the PR. Is that not true -- i.e. does DO_NOT_AUTOCLOSE also block closing on merge?

If so, is there a way to keep the "one-year bot" from closing it, without blocking closing on merge with keywords?

@jhux2 jhux2 added this to Tpetra Aug 12, 2024
@jhux2 jhux2 moved this to Done in Tpetra Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO_NOT_AUTOCLOSE This issue should be exempt from auto-closing by the GitHub Actions bot. pkg: Tpetra type: enhancement Issue is an enhancement, not a bug
Projects
Status: Done
Development

No branches or pull requests

5 participants