Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Remove Details::assumeMpiIsCudaAware in favor of Behavior::assumeMpiIsCudaAware #6873

Closed
mhoemmen opened this issue Feb 20, 2020 · 2 comments
Closed

Tpetra: Remove Details::assumeMpiIsCudaAware in favor of Behavior::assumeMpiIsCudaAware #6873

mhoemmen opened this issue Feb 20, 2020 · 2 comments
Labels
pkg: Tpetra system: gpu type: bug The primary issue is a bug in Trilinos code or tests

Comments

@mhoemmen
Copy link
Contributor

Bug Report

@trilinos/tpetra

Description

Remove Tpetra::Details::assumeMpiIsCudaAware (and its header file) in favor of Tpetra::Details::Behavior::assumeMpiIsCudaAware. See discussion here. The two functions are redundant, and Behavior defines the default behavior that we want.
@mhoemmen mhoemmen added type: bug The primary issue is a bug in Trilinos code or tests pkg: Tpetra system: gpu labels Feb 20, 2020
@kddevin
Copy link
Contributor

kddevin commented Feb 20, 2020

I am already removing this function. See #6796

@kddevin kddevin mentioned this issue Feb 20, 2020
Merged
@kddevin
Copy link
Contributor

kddevin commented Feb 25, 2020

Done.

@kddevin kddevin closed this as completed Feb 25, 2020
@trilinos-autotester trilinos-autotester mentioned this issue Jun 2, 2020
Merged
@trilinos-autotester trilinos-autotester mentioned this issue Mar 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Tpetra system: gpu type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoemmen @kddevin