Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoltan2: reversal of Cuthill McKee ordering is incorrect #6735

Closed
jhux2 opened this issue Feb 4, 2020 · 2 comments
Closed

Zoltan2: reversal of Cuthill McKee ordering is incorrect #6735

jhux2 opened this issue Feb 4, 2020 · 2 comments
Assignees
@jhux2
Labels
pkg: Zoltan2 type: bug The primary issue is a bug in Trilinos code or tests

Comments

@jhux2
Copy link
Member

jhux2 commented Feb 4, 2020

The reversal of the Cuthill McKee ordering in Zoltan2_AlgRCM.hpp is incorrect. This can result in orderings that make the matrix bandwidth worse than the original bandwidth.
@jhux2 jhux2 added type: bug The primary issue is a bug in Trilinos code or tests pkg: Zoltan2 labels Feb 4, 2020
@jhux2 jhux2 self-assigned this Feb 4, 2020
@jhux2
Copy link
Member Author

jhux2 commented Feb 4, 2020

@trilinos/zoltan2

@jhux2 jhux2 mentioned this issue Feb 4, 2020
Merged
@vbrunini
Copy link
Contributor

vbrunini commented Feb 4, 2020

This fixed all of our regression tests where reordering was the difference between the solves converging or not with Aztec. Thanks!

@kddevin kddevin mentioned this issue Feb 5, 2020
Merged
kddevin added a commit that referenced this issue Feb 5, 2020
@kddevin
Merge pull request #6750 from trilinos/zoltan2-test-6375
aa11e22 
Zoltan2:  upgraded testing for issue #6735 and PR #6736
@jhux2 jhux2 closed this as completed Feb 5, 2020
@jhux2 jhux2 mentioned this issue Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhux2 jhux2

Labels
pkg: Zoltan2 type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbrunini @jhux2