Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MueLu: re-work needed in uncoupled aggregation kokkos for dirichlet BC #6269

Closed
lucbv opened this issue Nov 13, 2019 · 1 comment
Closed

MueLu: re-work needed in uncoupled aggregation kokkos for dirichlet BC #6269

lucbv opened this issue Nov 13, 2019 · 1 comment
Assignees
@lucbv
Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code client: ExaWind All issue that impact the ECP project ExaWind pkg: MueLu type: enhancement Issue is an enhancement, not a bug

Comments

@lucbv
Copy link
Contributor

lucbv commented Nov 13, 2019

Enhancement

@trilinos/muelu

PR #6268 is adding code in the refactored uncoupled aggregation that will need to be reworked to have it run on device instead of copying back and forth between host and device.
This issue is here to remind us to take care of that in the future.
@lucbv lucbv added type: enhancement Issue is an enhancement, not a bug pkg: MueLu client: EMPIRE All issues that most directly target the ATDM EMPIRE code client: ExaWind All issue that impact the ECP project ExaWind labels Nov 13, 2019
@lucbv lucbv self-assigned this Nov 13, 2019
@lucbv lucbv changed the title PackageName: General Summary of the Enhancement MueLu: re-work needed in uncoupled aggregation kokkos for dirichlet BC Nov 13, 2019
@lucbv lucbv mentioned this issue Nov 13, 2019
Merged
lucbv added a commit to lucbv/Trilinos that referenced this issue Nov 20, 2019
@lucbv
MueLu: refactor of Dirichlet conditions handling and changes in Uncou…
f8614f7 
…pledAggregation see issue trilinos#6269

Three main changes are made in this commit:
    1. the Dirichlet phase of aggregation is refactored and associted
    utilities in UncoupledAggregation are refactored using Kokkos.
    A related bug in AggregationPhase1_kokkos is fixed.

    2. the default behavior of UncoupledAggregation is changed.
    The BuildSerialAggregates method is removed from Phase 1
    which means that now aggregation will always be performed in
    parallel and on device if possible. It simplifies slightly the
    input parameters for aggregation.

    3. some preparations are made to change the coloring
    algorithm selection for UncoupledAggregation, ultiately it
    is desireable to run with something else than the host serial
    implementation of distance 2 coloring but more tests with the
    different coloring algorithms will be needed first.
lucbv added a commit to lucbv/Trilinos that referenced this issue Nov 20, 2019
@lucbv
MueLu: gold file rebase and change of logic for issue trilinos#6269
993df11 
This commits modifies ParameterListInterpeter to ignore non-deterministic output
 from the refactored uncoupled aggregation.
@lucbv lucbv mentioned this issue Nov 20, 2019
Merged
lucbv added a commit to lucbv/Trilinos that referenced this issue Nov 21, 2019
@lucbv
MueLu: refactor of Dirichlet conditions handling and changes in Uncou…
ba34963 
…pledAggregation see issue trilinos#6269

Three main changes are made in this commit:
    1. the Dirichlet phase of aggregation is refactored and associted
    utilities in UncoupledAggregation are refactored using Kokkos.
    A related bug in AggregationPhase1_kokkos is fixed.

    2. the default behavior of UncoupledAggregation is changed.
    The BuildSerialAggregates method is removed from Phase 1
    which means that now aggregation will always be performed in
    parallel and on device if possible. It simplifies slightly the
    input parameters for aggregation.

    3. some preparations are made to change the coloring
    algorithm selection for UncoupledAggregation, ultiately it
    is desireable to run with something else than the host serial
    implementation of distance 2 coloring but more tests with the
    different coloring algorithms will be needed first.
lucbv added a commit to lucbv/Trilinos that referenced this issue Nov 21, 2019
@lucbv
MueLu: gold file rebase and change of logic for issue trilinos#6269
e3fcdc9 
This commits modifies ParameterListInterpeter to ignore non-deterministic output
 from the refactored uncoupled aggregation.
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Nov 22, 2019
Merge 'trilinos/Trilinos:develop' (98104b0) into 'tcad-charon/Trilino…
03d0693 
…s:develop' (1683f23).

* trilinos-develop:
  MueLu: gold file rebase and change of logic for issue trilinos#6269
  MueLu: refactor of Dirichlet conditions handling and changes in UncoupledAggregation see issue trilinos#6269
  Intrepid2: tweaks to OrientationTools::modifyBasisByOrientation() to allow reference-space inputs.
  Tempus: Add Cleanup of Error Tolerances.
  SEACAS: kluge to get new lib::fmt maybe working with nvcc
  Intrepid2: fixing issues with hierarchical parallelism policies, revealed when Trilinos is built with KOKKOS_ENABLE_DEPRECATED_CODE=OFF. (trilinos#6310)
  SEACAS: Another try at fixing nvcc build
  MueLu: fix type handling in regionMG unit test
  MueLu: remove debug output from regionMG unit test
  SEACAS: Attempt to fix CUDA compile errors
  Attempt to fix NVCC / INTEL compiler errors
  MueLu: fix misleading comments in regionMG unit tests
  Automatic snapshot commit from seacas at a34490f
  MueLu: adding region vector unit-test. Added tests for regionalToComposite and compositeToRegional.
@lucbv
Copy link
Contributor Author

lucbv commented Nov 22, 2019

This is now resolved with PR #6315 being merged

@lucbv lucbv closed this as completed Nov 22, 2019
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Nov 23, 2019
Merge 'trilinos/Trilinos:develop' (e55a0e5) into 'tcad-charon/Trilino…
91a4b2e 
…s:develop' (1683f23).

* trilinos-develop: (21 commits)
  MueLu: fixing the count of aggregated nodes in refactored Phase2a of aggregation, see trilinos#6325
  Teuchos StackedTimer: add unit test for 'proc_minmax'
  Teuchos StackedTimer: Print min time over all ranks that are active only
  Teuchos StackedTimer: add option to print rank with min/max time
  SEACAS: Bug fix since snapshot
  Reduce to ctest -j4 in all documentation (trilinos#6052)
  MueLu RefMaxwell: Print more matrix stats
  MueLu: gold file rebase and change of logic for issue trilinos#6269
  MueLu: refactor of Dirichlet conditions handling and changes in UncoupledAggregation see issue trilinos#6269
  Intrepid2: tweaks to OrientationTools::modifyBasisByOrientation() to allow reference-space inputs.
  Tempus: Add Cleanup of Error Tolerances.
  SEACAS: kluge to get new lib::fmt maybe working with nvcc
  Intrepid2: fixing issues with hierarchical parallelism policies, revealed when Trilinos is built with KOKKOS_ENABLE_DEPRECATED_CODE=OFF. (trilinos#6310)
  SEACAS: Another try at fixing nvcc build
  MueLu: fix type handling in regionMG unit test
  MueLu: remove debug output from regionMG unit test
  SEACAS: Attempt to fix CUDA compile errors
  Attempt to fix NVCC / INTEL compiler errors
  MueLu: fix misleading comments in regionMG unit tests
  Automatic snapshot commit from seacas at a34490f
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Nov 23, 2019
Merge 'trilinos/Trilinos:develop' (e55a0e5) into 'tcad-charon/Trilino…
542eb98 
…s:develop' (1683f23).

* trilinos-develop: (21 commits)
  MueLu: fixing the count of aggregated nodes in refactored Phase2a of aggregation, see trilinos#6325
  Teuchos StackedTimer: add unit test for 'proc_minmax'
  Teuchos StackedTimer: Print min time over all ranks that are active only
  Teuchos StackedTimer: add option to print rank with min/max time
  SEACAS: Bug fix since snapshot
  Reduce to ctest -j4 in all documentation (trilinos#6052)
  MueLu RefMaxwell: Print more matrix stats
  MueLu: gold file rebase and change of logic for issue trilinos#6269
  MueLu: refactor of Dirichlet conditions handling and changes in UncoupledAggregation see issue trilinos#6269
  Intrepid2: tweaks to OrientationTools::modifyBasisByOrientation() to allow reference-space inputs.
  Tempus: Add Cleanup of Error Tolerances.
  SEACAS: kluge to get new lib::fmt maybe working with nvcc
  Intrepid2: fixing issues with hierarchical parallelism policies, revealed when Trilinos is built with KOKKOS_ENABLE_DEPRECATED_CODE=OFF. (trilinos#6310)
  SEACAS: Another try at fixing nvcc build
  MueLu: fix type handling in regionMG unit test
  MueLu: remove debug output from regionMG unit test
  SEACAS: Attempt to fix CUDA compile errors
  Attempt to fix NVCC / INTEL compiler errors
  MueLu: fix misleading comments in regionMG unit tests
  Automatic snapshot commit from seacas at a34490f
  ...
searhein pushed a commit to searhein/Trilinos that referenced this issue Nov 25, 2019
Merge branch 'develop' of https://github.com/trilinos/Trilinos into o…
4ddc728 
…ne-to-one

* 'develop' of https://github.com/trilinos/Trilinos: (38 commits)
  MueLu RefMaxwell: Fix bug in ParameterList interface
  tpetra:  converted constant to scalar_type; needed to enable compilation when scalar_type = std::complex<float>  (as noted in trilinos#6314)
  tpetra:  loosened tolerance that was too tight when scalar=float
  MueLu PerfUtils: Show ranks with min/max
  MueLu RefMaxwell: More fine grained control over sub-solve placement
  MueLu: fixing the count of aggregated nodes in refactored Phase2a of aggregation, see trilinos#6325
  Teuchos StackedTimer: add unit test for 'proc_minmax'
  Teuchos StackedTimer: Print min time over all ranks that are active only
  Teuchos StackedTimer: add option to print rank with min/max time
  SEACAS: Bug fix since snapshot
  Reduce to ctest -j4 in all documentation (trilinos#6052)
  MueLu RefMaxwell: Print more matrix stats
  MueLu: gold file rebase and change of logic for issue trilinos#6269
  MueLu: refactor of Dirichlet conditions handling and changes in UncoupledAggregation see issue trilinos#6269
  Intrepid2: tweaks to OrientationTools::modifyBasisByOrientation() to allow reference-space inputs.
  Tempus: Add Cleanup of Error Tolerances.
  SEACAS: kluge to get new lib::fmt maybe working with nvcc
  Intrepid2: fixing issues with hierarchical parallelism policies, revealed when Trilinos is built with KOKKOS_ENABLE_DEPRECATED_CODE=OFF. (trilinos#6310)
  SEACAS: Another try at fixing nvcc build
  MueLu: fix type handling in regionMG unit test
  ...
@jhux2 jhux2 added this to MueLu Aug 12, 2024
@jhux2 jhux2 moved this to Done in MueLu Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucbv lucbv

Labels
client: EMPIRE All issues that most directly target the ATDM EMPIRE code client: ExaWind All issue that impact the ECP project ExaWind pkg: MueLu type: enhancement Issue is an enhancement, not a bug
Projects
MueLu
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucbv