Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra::CrsMatrix::globalAssemble broken with overlapping row Map #603

Closed
mhoemmen opened this issue Sep 9, 2016 · 3 comments
Closed

Tpetra::CrsMatrix::globalAssemble broken with overlapping row Map #603

mhoemmen opened this issue Sep 9, 2016 · 3 comments
Assignees
@mhoemmen
Labels
pkg: Tpetra

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Sep 9, 2016 •
edited
Loading

@trilinos/tpetra See #601 for discussion.
This depends on #607.
@mhoemmen mhoemmen self-assigned this Sep 9, 2016
This was referenced Sep 9, 2016
Closed
Closed
@mhoemmen mhoemmen added stage: in progress Work on the issue has started stage: in review Primary work is completed and now is just waiting for human review and/or test feedback and removed stage: in progress Work on the issue has started labels Sep 14, 2016
@mhoemmen
Copy link
Contributor Author

Tests were passing yesterday. One unrelated (Piro Epetra) check-in test failed last night, so I'm rerunning the check-in test script with that test excluded.

@mhoemmen
Copy link
Contributor Author

MPI_DEBUG tests passed. SERIAL_RELEASE build running now.

mhoemmen pushed a commit that referenced this issue Sep 14, 2016
Tpetra::CrsMatrix: Fix #603 (globalAssemble w/ overlapping row Map)
40dd135 
@trilinos/tpetra Fix #603.  Tpetra::CrsMatrix::globalAssemble now
works even if the matrix's row Map is overlapping.  The implementation
should also be much more efficient.  Nevertheless, we still prefer
that users manage global assembly themselves using the two-matrix
Export approach.

This fix leverages the fix for #607, to make sure that CrsMatrix's
"BadGID" test still passes.

Build/Test Cases Summary
Enabled Packages: TpetraCore
Disabled Packages: FEI,PyTrilinos,Moertel,STK,SEACAS,ThreadPool,OptiPack,Rythmos,Intrepid,ROL,Panzer
Enabled all Forward Packages
0) MPI_DEBUG => Test case MPI_DEBUG was not run! => Does not affect push readiness! (-1.00 min)
1) SERIAL_RELEASE => Test case SERIAL_RELEASE was not run! => Does not affect push readiness! (-1.00 min)
2) MPI_DEBUG => passed: passed=684,notpassed=0 (64.88 min)
3) SERIAL_RELEASE => passed: passed=589,notpassed=0 (24.44 min)
Other local commits for this build/test group: ce52b64
@mhoemmen
Copy link
Contributor Author

Tests passed; pushed changes.

@mhoemmen mhoemmen removed the stage: in review Primary work is completed and now is just waiting for human review and/or test feedback label Sep 14, 2016
mhoemmen pushed a commit that referenced this issue Sep 14, 2016
Tpetra::CrsMatrix: Get rid of CrsIJV
41c5735 
@trilinos/tpetra Tpetra::CrsMatrix::globalAssemble used to depend on
Tpetra::Details::CrsIJV and the specialization of
Teuchos::SerializationTraits for that class.  My recently pushed fix
for #603 makes CrsIJV unnecessary.  This commit removes it.
This was referenced Sep 16, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhoemmen mhoemmen

Labels
pkg: Tpetra
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhoemmen