Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing MueLu tests on perseus #599

Closed
tawiesn opened this issue Sep 7, 2016 · 4 comments
Closed

Failing MueLu tests on perseus #599

tawiesn opened this issue Sep 7, 2016 · 4 comments
Labels
impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) pkg: MueLu

Comments

@tawiesn
Copy link
Contributor

tawiesn commented Sep 7, 2016

The tests here are failing.

According to the configuration output it uses a current Trilinos version (e.g., from Sep 2).

I tried to reproduce the problem (using gcc instead of intel, since i have no SEMS environment on my machine), but it is not even linking on my machine.

Processing enabled package: Tpetra (Classic, Kernels, TSQR, Core)
-- NOTE: Kokkos::Serial is ON (the CMake option Kokkos_ENABLE_Serial is ON), but the corresponding Tpetra Node type is disabled.  If you want to enable instantiation and use of Kokkos::Serial in Tpetra, please also set the CMake option Tpetra_INST_SERIAL:BOOL=ON.  If you use the Kokkos::Serial Node type in Tpetra without doing this, you will get link errors!
-- Tpetra execution space availability (ON means available): 
--   - Serial:  OFF
--   - Threads: ON
--   - OpenMP:  OFF
--   - Cuda:    OFF
-- User-set default Node: Kokkos::Compat::KokkosThreadsWrapperNode
-- Not enabling Tpetra/RTI
Processing enabled package: Xpetra (Libs)
-- Xpetra support for 32 bit Epetra enabled.
--    Xpetra_Epetra_NO_32BIT_GLOBAL_INDICES=OFF
-- Xpetra support for 64 bit Epetra enabled.
--    Xpetra_Epetra_NO_64BIT_GLOBAL_INDICES=OFF
...
Processing enabled package: MueLu (Libs, Tests, Examples)
-- MueLu ETI support enabled
-- <float,   int, int>       : OFF
-- <double,  int, int>       : ON
-- <double,  int, long>      : OFF
-- <double,  int, long long> : ON
-- <complex, int, int>       : OFF
-- HAVE_MUELU_SERIAL       : ON
-- HAVE_MUELU_PTHREAD      : ON
-- HAVE_MUELU_OPENMP       : OFF
-- HAVE_MUELU_CUDA         : OFF

So, i don't know what exactly runs in that test.

@tawiesn tawiesn added pkg: MueLu impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) labels Sep 7, 2016
@jhux2
Copy link
Member

jhux2 commented Sep 8, 2016

@trilinos/muelu

@aprokop
Copy link
Contributor

aprokop commented Sep 8, 2016

The issue is obvious: Zoltan2Interface does not have "number of partitions" in the GetValidParameterList.

Also, why is GetValidParameterList definition is in the MueLu_Zoltan2Interface_decl.hpp instead of _def.hpp? This is against the normal approach.

@tawiesn
Copy link
Contributor Author

tawiesn commented Sep 8, 2016

@aprokop You're right. The "number of partitions" was missing in the Epetra specialization of the Zoltan2Interface. I forgot to add it there (since i didn't expect it in the *_decl.hpp file).

In the *_decl.hpp file we have a specialization of the Zoltan2Interface for Epetra which either uses Zoltan instead of Zoltan2 underneath or provides a stub implementation. I think the reason was that we wanted to test the repartitioning using Zoltan/Zoltan2 with only one testing stack (i.e. Zoltan2Interface in the xml files). In case of Epetra it was supposed to fall back to using Zoltan. I don't know whether there was a specific reason why we did not want to use Zoltan2 with Epetra. Maybe, it was because we could not check whether Zoltan has been compiled with Epetra support or not. One probably should check the HAVE_ZOLTAN2_EPETRA flag and adapt the guards in Zoltan2Interface accordingly.

The checkin script is running to fix the problem with "number of partitions". I will file a new issue about the Zoltan2Interface and Epetra support.

@aprokop
Copy link
Contributor

aprokop commented Sep 8, 2016

OK. I did not notice the stub.

@tawiesn tawiesn closed this as completed Sep 26, 2016
brian-kelley added a commit to brian-kelley/Trilinos that referenced this issue Feb 6, 2020
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 7, 2020
…s:develop' (2bfd2c7).

* trilinos-develop: (245 commits)
  Fixed CMake typo
  Mirror of KokkosKernels trilinos#599
  tpetra: MV packAndPrepare fix
  Tpetra: adding more fine grained timing in MatVec Benchmark
  ATDM: ats2: switch to ninja (CDOFA-72)
  tpetra: Add sync check in MV packAndPrepare
  Remove unnecessary cdash warnings
  Teuchos: Reduce SWIG 4 warnings on doxygen comments
  ATDM: More cleanup after Kokkos 2.99 upgrade
  Amesos: Adjust doxygen comments for SWIG 4.0
  Tpetra: Adjust doxygen comments for SWIG 4.0
  Teuchos: Adjust doxygen comments for SWIG 4.0
  NOX/LOCA: Adjust doxygen comments for SWIG 4.0
  ML: Adjust doxygen comments for SWIG 4.0
  Isorropia: Adjust doxygen comments for SWIG 4.0
  Ifpack: Adjust doxygen comments for SWIG 4.0
  EpetraExt: Adjust doxygen comments for SWIG 4.0
  Epetra: Adjust doxygen comments for SWIG 4.0
  AztecOO: Adjust doxygen comments for SWIG 4.0
  Anasazi: Adjust doxygen comments for SWIG 4.0
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 8, 2020
…s:develop' (2bfd2c7).

* trilinos-develop: (248 commits)
  panzer dof-mgr: add needed check and sync for MV dual view
  PyTrilinos: Fix syntax error only seen with SWIG < 4.0
  Fixed CMake typo
  Mirror of KokkosKernels trilinos#599
  tpetra: MV packAndPrepare fix
  Tpetra: adding more fine grained timing in MatVec Benchmark
  ATDM: ats2: switch to ninja (CDOFA-72)
  tpetra: Add sync check in MV packAndPrepare
  Remove unnecessary cdash warnings
  Teuchos: Reduce SWIG 4 warnings on doxygen comments
  ATDM: More cleanup after Kokkos 2.99 upgrade
  Amesos: Adjust doxygen comments for SWIG 4.0
  Tpetra: Adjust doxygen comments for SWIG 4.0
  Teuchos: Adjust doxygen comments for SWIG 4.0
  NOX/LOCA: Adjust doxygen comments for SWIG 4.0
  ML: Adjust doxygen comments for SWIG 4.0
  Isorropia: Adjust doxygen comments for SWIG 4.0
  Ifpack: Adjust doxygen comments for SWIG 4.0
  EpetraExt: Adjust doxygen comments for SWIG 4.0
  Epetra: Adjust doxygen comments for SWIG 4.0
  ...
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Feb 8, 2020
…s:develop' (2bfd2c7).

* trilinos-develop: (248 commits)
  panzer dof-mgr: add needed check and sync for MV dual view
  PyTrilinos: Fix syntax error only seen with SWIG < 4.0
  Fixed CMake typo
  Mirror of KokkosKernels trilinos#599
  tpetra: MV packAndPrepare fix
  Tpetra: adding more fine grained timing in MatVec Benchmark
  ATDM: ats2: switch to ninja (CDOFA-72)
  tpetra: Add sync check in MV packAndPrepare
  Remove unnecessary cdash warnings
  Teuchos: Reduce SWIG 4 warnings on doxygen comments
  ATDM: More cleanup after Kokkos 2.99 upgrade
  Amesos: Adjust doxygen comments for SWIG 4.0
  Tpetra: Adjust doxygen comments for SWIG 4.0
  Teuchos: Adjust doxygen comments for SWIG 4.0
  NOX/LOCA: Adjust doxygen comments for SWIG 4.0
  ML: Adjust doxygen comments for SWIG 4.0
  Isorropia: Adjust doxygen comments for SWIG 4.0
  Ifpack: Adjust doxygen comments for SWIG 4.0
  EpetraExt: Adjust doxygen comments for SWIG 4.0
  Epetra: Adjust doxygen comments for SWIG 4.0
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impacting: tests The defect (bug) is primarily a test failure (vs. a build failure) pkg: MueLu
Projects
None yet
Development

No branches or pull requests

3 participants