Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pamgen: Remove Build Warnings #5104

Closed
ZUUL42 opened this issue May 6, 2019 · 1 comment
Closed

Pamgen: Remove Build Warnings #5104

ZUUL42 opened this issue May 6, 2019 · 1 comment
Labels
pkg: Pamgen type: enhancement Issue is an enhancement, not a bug

Comments

@ZUUL42
Copy link
Contributor

ZUUL42 commented May 6, 2019

Enhancement

@trilinos/pamgen

Issue #3178 is working toward turning Warnings as Errors on for all packages in order in ensure Trilinos maintains a high level of SQA practices across the project.
Currently Pamgen has a warning that need to be handled before we can set Werror for Pamgen and eventually all packages.

A recent test build was performed with -Werror set. The CDash report can be found here.
Once the Pamgen build doesn't emit any warnings that will be promoted to errors, we can set -Werror in the GCC 7.2.0 automated build.

@ZUUL42 ZUUL42 added type: enhancement Issue is an enhancement, not a bug pkg: Pamgen labels May 6, 2019
@csiefer2
Copy link
Member

csiefer2 commented May 6, 2019

Looks like all you have to do is comment out one line. Give it a go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: Pamgen type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

No branches or pull requests

2 participants