Remove redundant TriBITS includes in CMakeLists.txt files

[bartlettroscoe]

Next Action Status:

Changes accepted for SEACAS github repo. Changes for native Trilinos packages pushed. Next: Wait for STK to make changes in native repo and Kokkos to accept PR ...

CC: @trilinos/framework

Description

A long time ago, TriBITS added all the includes needed to process project, repository, and package files to the TriBITS.cmake file. This avoids the need to include the same files over and over again in user *.cmake and CMakeLists.txt files. This removes clutter and speeds up configures.

There is a single script in TriBITS that automatically does this upgrade:

TriBITS/refactoring/remove_std_tribits_includes_r.sh

[bartlettroscoe]

Looks like most of the redundant includes are in SEACAS and STK. I will issue tickets in their native issue tracker systems to run the update script. Actually, for SEACAS I can just do a PR on the independent SEACAS git repo. I will take care of the other packages that I can change.

[bartlettroscoe]

Greg already merged my PR to remove the redundant includes from the SEACAS repo (see sandialabs/seacas#52).

Remaining packages that have includes that should be removed include:

• DOMI: @wfspotz
• Intrepid2: @trilinos/intrepid2
• Kokkos: @crtrott
• MueLu: @trilinos/muelu
• Phalanx: @trilinos/phalanx
• PIKE: @rppawlo
• ROL: @trilinos/rol
• ShyLU: @trilinos/shylu
• STK: @trilinos/stk
• Stokhos: @trilinos/stokhos
• Xpetra: @trilinos/xpetra

I will apply the refactoring script to all of the packages, command and push for all of the packages except for STK and Kokkos. This just a heads up for the packages other thank STK and Kokkos.

For STK, I will file a Trac ticket for STK against the native issue tracking system for STK.

For Kokkos, I will issue a PR against their github repo.

[bartlettroscoe]

For STK, I created the native STK Trac issue #15252 for this.

For Kokkos, I created kokkos/kokkos#358.

Now for the rest of the packages.

[bartlettroscoe]

All that is left to do is:

• Kokkos developers to accept Remove redundant TriBITS includes kokkos/kokkos#358 and then sync kokkos to Trilinos
• STK to run the refactoring script, push to their repo, then sync STK into Trilinos

[bartlettroscoe]

The PR kokkos/kokkos#358 was accepted and the Kokkos snapshot:

$ git log --name-status -1 -SINCLUDE -- packages/kokkos/

commit 23a068986de5d41168a9db918b8fbfc37705ab92
Author: crtrott <[email protected]>
Date:   Fri Sep 2 13:52:12 2016 -0600

    Snapshot of kokkos from commit e41193250907211302bdb94aa55044489c8145d0
    
    From repository at [email protected]:kokkos/kokkos
    
    At commit:
    commit e41193250907211302bdb94aa55044489c8145d0
    Merge: 9afaa87 555f1a3
    Author: crtrott <[email protected]>
    Date:   Fri Sep 2 13:33:42 2016 -0600
    
        Merge remote-tracking branch 'origin/develop'

M       packages/kokkos/example/sort_array/CMakeLists.txt

brought this into Trilinos.

Also, the STK developers ran the TriBITS refactoring script and the following commit was recently synced to Trilinos:

commit b85d6f8ecc8958004b6ca9f16faadd12a6a75836
Author: Kendall Hugh Pierson <[email protected]>
Date:   Mon Aug 1 14:38:02 2016 -0600

    stk: Run tribits refactoring script on CMakeLists
    
     This commit only touches CMakeLists files for building
     stk within trilinos.
    
    (From STK/SEACAS)

M       packages/stk/CMakeLists.txt
M       packages/stk/stk_classic/CMakeLists.txt
M       packages/stk/stk_classic/stk_algsup/stk_algsup/CMakeLists.txt
M       packages/stk/stk_classic/stk_algsup/unit_tests/CMakeLists.txt
M       packages/stk/stk_classic/stk_expreval/stk_expreval/CMakeLists.txt
...

This story is complete.