Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teuchos::ScalarTraits has no specialization for Kokkos:complex<T> #4726

Closed
csiefer2 opened this issue Mar 26, 2019 · 2 comments
Closed

Teuchos::ScalarTraits has no specialization for Kokkos:complex<T> #4726

csiefer2 opened this issue Mar 26, 2019 · 2 comments
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package

Comments

@csiefer2
Copy link
Member

csiefer2 commented Mar 26, 2019 •
edited by mhoemmen
Loading

We should probably fix this at some point.

Related issues

Blocks #5263
@csiefer2 csiefer2 added the pkg: Teuchos Issues primarily dealing with the Teuchos Package label Mar 26, 2019
@mhoemmen mhoemmen changed the title Teuchos::ScalarTraits is not instantiated for Kokkos:complex Teuchos::ScalarTraits has no specialization for Kokkos:complex<T> Mar 26, 2019
@mhoemmen
Copy link
Contributor

mhoemmen commented Mar 26, 2019 •
edited
Loading

@trilinos/teuchos

KokkosCore is already an optional dependency of TeuchosCore, so we should be able to add this to Teuchos_ScalarTraits.hpp, as long as we protect the Kokkos_Complex.hpp include and all Kokkos::complex<T> use with the appropriate macro.

@mhoemmen
Copy link
Contributor

This is related to #5269.

This was referenced May 28, 2019
Closed
Merged
@trilinos-autotester trilinos-autotester mentioned this issue Feb 18, 2022
Merged
@trilinos-autotester trilinos-autotester mentioned this issue Apr 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkg: Teuchos Issues primarily dealing with the Teuchos Package
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhoemmen @csiefer2