Stratimikos: "declaration shadows a typedef" warnings from Apple clang 10.0.0

[CamelliaDPG]

@trilinos/stratimikos

Expectations

Builds with clang that use the -Wshadow flag should not emit warnings.

Current Behavior

One warning is emitted by clang when building BelosThyraAdapter.hpp.

.../include/BelosThyraAdapter.hpp:301:49: warning: declaration shadows a typedef in 'MultiVecTraits<type-parameter-0-0, MultiVectorBase<type-parameter-0-0> >' [-Wshadow]
      typedef Teuchos::ScalarTraits<ScalarType> ST;
                                                ^
.../include/BelosThyraAdapter.hpp:87:47: note: previous declaration is here
    typedef Teuchos::ScalarTraits<ScalarType> ST;

Possible Solution

Since the shadowing typedef is identical to the shadowed typedef, likely the correct solution is simply to delete the shadowing typedef (delete line 301).

Environment

I'm building on a Mac using Apple clang 10.0.0.

[github-actions]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[github-actions]

This issue was closed due to inactivity for 395 days.