Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: sort and merge values: CrsMatrix::insertLocalValues #4281

Closed
tjfulle opened this issue Jan 28, 2019 · 2 comments
Closed

Tpetra: sort and merge values: CrsMatrix::insertLocalValues #4281

tjfulle opened this issue Jan 28, 2019 · 2 comments
Assignees
@tjfulle
Labels
pkg: Tpetra TpetraRF
Milestone
Tpetra: Deprecate...

Comments

@tjfulle
Copy link
Contributor

tjfulle commented Jan 28, 2019

What

Sort and merge new values in CrsMatrix::insertLocalValues

Why

CrsMatrix::insertLocalValues does not sort/merge existing values. Instead, indices/values are appended to their row of the matrix, regardless if they are already present in the row. During fillComplete, rows are sorted/merged so that duplicate entries are "compressed" out. For StaticProfile matrix, this can lead to running out of capacity due to duplicate entries.

@trilinos/tpetra

Related Issues

#4278, #4279, #4280
@tjfulle tjfulle added pkg: Tpetra TpetraRF AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed labels Jan 28, 2019
@tjfulle tjfulle self-assigned this Jan 28, 2019
@tjfulle tjfulle mentioned this issue Jan 28, 2019
Closed
@tjfulle tjfulle removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label Jan 28, 2019
@mhoemmen mhoemmen mentioned this issue Feb 8, 2019
Merged
18 tasks
@tjfulle
Copy link
Contributor Author

tjfulle commented Mar 28, 2019

This is done in #4733. indices are not sorted/merged, but are unique.

@tjfulle tjfulle mentioned this issue Mar 28, 2019
Merged
@mhoemmen
Copy link
Contributor

Closed by PR #4733.

@trilinos-autotester trilinos-autotester mentioned this issue Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjfulle tjfulle

Labels
pkg: Tpetra TpetraRF
Projects
None yet
Milestone
Tpetra: Deprecate DynamicProfile
Development

No branches or pull requests
2 participants
@mhoemmen @tjfulle