Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xpetra: Clang warnings about explicit instantiations having no effect #3059

Closed
mhoemmen opened this issue Jul 4, 2018 · 2 comments
Closed
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Xpetra

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Jul 4, 2018

@trilinos/xpetra @trilinos/muelu

Clang emits interesting warnings about certain Xpetra explicit instantiations having no effect. I'm curious whether this means that code doesn't behave like one things it might. Here are the warnings:

[ 77%] Building CXX object packages/xpetra/src/CMakeFiles/xpetra.dir/Vector/Xpetra_EpetraVector.cpp.o
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraVector.cpp:77:16: warning: explicit instantiation of 'EpetraVectorT<int,
      Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> >' that occurs after an explicit specialization has no effect
      [-Winstantiation-after-specialization]
template class EpetraVectorT<int, Kokkos::Compat::KokkosSerialWrapperNode >;
               ^
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraVector.hpp:245:7: note: previous template specialization is here
class EpetraVectorT<int, EpetraNode>
      ^
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraVector.cpp:117:16: warning: explicit instantiation of 'EpetraVectorT<long long,
      Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> >' that occurs after an explicit specialization has no effect
      [-Winstantiation-after-specialization]
template class EpetraVectorT<long long, Kokkos::Compat::KokkosSerialWrapperNode >;
               ^
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraVector.hpp:432:7: note: previous template specialization is here
class EpetraVectorT<long long, EpetraNode>
      ^
2 warnings generated.
[ 77%] Building CXX object packages/xpetra/src/CMakeFiles/xpetra.dir/Vector/Xpetra_EpetraIntVector.cpp.o
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraIntVector.cpp:77:16: warning: explicit instantiation of 'EpetraIntVectorT<int,
      Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> >' that occurs after an explicit specialization has no effect
      [-Winstantiation-after-specialization]
template class EpetraIntVectorT<int, Kokkos::Compat::KokkosSerialWrapperNode >;
               ^
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraIntVector.hpp:371:9: note: previous template specialization is here
  class EpetraIntVectorT<int, EpetraNode>
        ^
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraIntVector.cpp:116:16: warning: explicit instantiation of 'EpetraIntVectorT<long long,
      Kokkos::Compat::KokkosDeviceWrapperNode<Kokkos::Serial, Kokkos::HostSpace> >' that occurs after an explicit specialization has no effect
      [-Winstantiation-after-specialization]
template class EpetraIntVectorT<long long, Kokkos::Compat::KokkosSerialWrapperNode >;
               ^
.../Trilinos/packages/xpetra/src/Vector/Xpetra_EpetraIntVector.hpp:810:9: note: previous template specialization is here
  class EpetraIntVectorT<long long, EpetraNode>
        ^
2 warnings generated.
@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Jul 10, 2021
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Xpetra
Projects
None yet
Development

No branches or pull requests

1 participant