Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stokhos: Remove calls to deprecated Kokkos::View methods #2718

Closed
mhoemmen opened this issue May 10, 2018 · 2 comments
Closed

Stokhos: Remove calls to deprecated Kokkos::View methods #2718

mhoemmen opened this issue May 10, 2018 · 2 comments
Assignees

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented May 10, 2018

Kokkos will soon deprecate the following Kokkos::View methods:

  1. ptr_on_device(): replace with data()
  2. dimension(N) (for N = 0, 1, 2, ..., 7): replace with extent(N)
  3. dimension_N() (for N = 0, 1, 2, ..., 7): replace with extent(N)
  4. is_contiguous(): replace with span_is_contiguous()
  5. capacity(): replace with span()

Sierra is already seeing build errors with its Trilinos integration build, since Sierra doesn't define KOKKOS_ENABLE_DEPRECATED_CODE. If that macro is not defined, code that uses the above methods will not build.

@trilinos/stokhos @etphipp

@mhoemmen mhoemmen changed the title Stokhos: Remove deprecated Kokkos::View methods Stokhos: Remove calls to deprecated Kokkos::View methods May 10, 2018
etphipp added a commit to etphipp/Trilinos that referenced this issue May 10, 2018
mhoemmen pushed a commit that referenced this issue May 11, 2018
@etphipp
Copy link
Contributor

etphipp commented May 11, 2018

Can this be closed now?

@mhoemmen
Copy link
Contributor Author

@etphipp yes; thanks! Please refer to #2735 for further Kokkos promotion issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants