Pull request testing uses really old OpenMPI 1.6.5 w/ build warnings

[mhoemmen]

Here is an example of the resulting build warnings:

https://testing-vm.sandia.gov/cdash/viewBuildError.php?type=1&buildid=3418378

In file included from /projects/sems/install/rhel6-x86_64/sems/compiler/gcc/4.9.3/openmpi/1.6.5/include/mpi.h:253:0,
                 from /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3@2/Trilinos/packages/ml/src/Comm/ml_comm.h:26,
                 from /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3@2/Trilinos/packages/ml/src/Main/ml_1level.h:31,
                 from /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3@2/Trilinos/packages/ml/src/Smoother/ml_smoother.h:40,
                 from /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3@2/Trilinos/packages/ml/src/Main/ml_struct.h:31,
                 from /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3@2/Trilinos/packages/ml/src/Include/ml_include.h:18,
                 from /scratch/trilinos/workspace/trilinos-folder/Trilinos_pullrequest_gcc_4.9.3@2/Trilinos/packages/ml/test/RefMaxwell/cxx_main.cpp:24:
[CTest: warning matched] /projects/sems/install/rhel6-x86_64/sems/compiler/gcc/4.9.3/openmpi/1.6.5/include/mpi_portable_platform.h:374:34: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
              _STRINGIFY(__GNUC__)"."_STRINGIFY(__GNUC_MINOR__)"."_STRINGIFY(__GNUC_PATCHLEVEL__)
                                  ^
[CTest: warning matched] /projects/sems/install/rhel6-x86_64/sems/compiler/gcc/4.9.3/openmpi/1.6.5/include/mpi_portable_platform.h:374:63: warning: invalid suffix on literal; C++11 requires a space between literal and string macro [-Wliteral-suffix]
              _STRINGIFY(__GNUC__)"."_STRINGIFY(__GNUC_MINOR__)"."_STRINGIFY(__GNUC_PATCHLEVEL__)
                                                               ^

OpenMPI calls their own version 1.6.5 "retired" and the next older one is called "ancient." Sierra uses 1.10.x.

@trilinos/framework

[mhoemmen]

@prwolfe

[prwolfe]

@mhoemmen

I believe this error shows up even when we don't have -Werror. In fact that compilation has

"-pedantic -Wall -Wno-long-long -Wwrite-strings" and I'm pretty sure that -std=c++11 is what enables this one.

I think we have plans for fixing both of these (adding warnings-as-errors slowly, and moving to a newer MPI.). I will check and get back to you.

[mhoemmen]

Thanks @prwolfe ! :D It sure would be nice not to have these extra warnings in PR testing....

[prwolfe]

@jwillenbring This is the only discussion I see on the openmpi 1.6.5 vs. 1.10.1 question. Everything else I see in the PR discussions either don't address the question or implicitly assume 1.10.x. I recommend we change the gcc 4.8.4 build as soon as possible and migrate the others forward one at a time over the next week or so considering #2974. Any thoughts?

[jwillenbring]

@prwolfe I agree we should move to 1.10.x in the way that you suggest. The only thing I would add is that we test the modified Jenkins configurations against a fork if we cannot use regular pull request testing to verify the mods so we don’t risk the other builds failing.

[prwolfe]

Will do.

[mhoemmen]

FYI 1.10.x is old enough that OpenMPI doesn't even support it any more, but that's a different issue ;-)

[github-actions]

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

[github-actions]

This issue was closed due to inactivity for 395 days.