Warnings-as-errors need cleaned up

[prwolfe]

All three builds that use watnings-as-errors are showing 50+ failures. We need to look into these to support customers that use this. See https://testing.sandia.gov/cdash/index.php?project=Trilinos&parentid=3400360

@trilinos/mesquite 11 errors from
packages/mesquite/src/Control/Mesquite_InstructionQueue.cpp due to unused variable
packages/mesquite/src/Control/Mesquite_TerminationCriterion.cpp due to unused variable
packages/mesquite/src/Mesh/Mesquite_ParallelHelper.cpp due to unsupported formatter to printf
packages/mesquite/src/ObjectiveFunction/Mesquite_ObjectiveFunction.cpp due to deprecated use of auto_ptr
packages/mesquite/src/QualityImprover/OptSolvers/Mesquite_ConjugateGradient.cpp due to warning about ambiguous else statement.
packages/mesquite/src/ObjectiveFunction/Mesquite_ObjectiveFunctionTemplate.cpp due to auto_ptr
packages/mesquite/src/QualityImprover/OptSolvers/Mesquite_NonGradient.cpp due to initialization order and format string to printf
packages/mesquite/src/QualityImprover/OptSolvers/Mesquite_QuasiNewton.cpp due to unused variable
packages/mesquite/src/QualityImprover/Mesquite_VertexMover.cpp due to unused variable
packages/mesquite/src/QualityMetric/Debug/Mesquite_CompareQM.cpp due to unused variable

Expectations

These warnings/errors should be resolved and the changes set as pull requests into develop to support Sierra and other codes. When those pull requests are merged the ticket should be closed.

In this case we need to talk with our upstream source for this (I'm not even sure who that is,) and see if we can get agreement to maintain this to this level.

Current Behavior

Warnings-as-errors builds fail on the above conditions

Motivation and Context

Definition of Done

Possible Solution

Steps to Reproduce

Your Environment

• Relevant repo SHA1s:
• Relevant configure flags or configure script:
• Operating system and version:
• Compiler and TPL versions:

Related Issues

• Blocks
• Is blocked by
• Follows
• Precedes
• Related to
• Part of
• Composed of

Additional Information

[jmgate]

Looks like @trilinos/mesquite isn't a team. @trilinos/framework, any idea who the right contact here is?

[bmpersc]

@jmgate, to my knowledge there is no contact for mesquite. The folks who were developing it have all left Sandia. There have been occasional rumblings of someone picking it up, but I don't know of anything official at this point.

Mesquite is an "external package" and of the 6 or so that we have of those only one is actively worked on. I'm of the opinion that we should probably just turn off all the external packages especially if they are causing issues. However, after a brief look at mesquite's warnings it seems that these warnings aren't likely to have implications for the computation so it might just be that the framework team can make the changes.

[jmgate]

Either way sounds fine to me. Do we have any way of archiving "dead" packages? Seems like we have a number that are no longer actively developed, but I don't know if they're still being used. They probably shouldn't just get deleted, but I'm not sure how we should indicate that a package is no longer really a supported part of Trilinos.

[prwolfe]

@bmpersc

I am happy to take this up if there is not a group. I take it the trilinos/Mesquite repo on git hub is the current code, but I do not see a develop branch.

[bmpersc]

@prwolfe, all of the external packages were broken off of Trilinos when we moved to github, which was before the master/develop change. I honestly don't know what the plan is or even should be for those defunct packages.

[jwillenbring]

They probably shouldn't just get deleted, but I'm not sure how we should indicate that a package is no longer really a supported part of Trilinos.

We could start by removing them from the list of released packages and from the release tarball.

[prwolfe]

I put this up as PR https://github.com/trilinos/mesquite/pull/3. I'm not sure why, but that repo won't let me add anyone as a reviewer - likely because no-one has worked in it before?

Fun times...

[mhoemmen]

@prwolfe I just reviewed and approved it, but I don't think I have merge permissions for that repo.

[prwolfe]

I noted the same thing. I sent a note to Jim and Brent.

[prwolfe]

Brent merged the PR and I see no errors this morning. Thanks Everyone!