Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROL: Explicitly uses GlobalOrdinal=int with Tpetra, doesn't need to #1585

Closed
mhoemmen opened this issue Aug 7, 2017 · 4 comments
Closed
Assignees
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: ROL

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Aug 7, 2017

@trilinos/rol
Line 292 of rol/example/PDE-OPT/TOOLS/assembler.hpp (in Trilinos develop) explicitly calls Tpetra::createOneToOne<int,int>. This forces use of GlobalOrdinal = int. See #74 for why we don't want this.

The line is easy to fix: just do this:

myUniqueStateMap_ = Tpetra::createOneToOne (myOverlapStateMap_);

That is, let createOneToOne deduce its template parameters on its own. It can do so by looking at the input argument.

There are a few other places in the file that force this constraint, e.g., line 231:

Teuchos::Array<int> myGlobalIds;

(replace int with GO and define GO as Tpetra::Map<>::global_ordinal_type).

@dridzal
Copy link
Contributor

dridzal commented Aug 8, 2017

@mhoemmen , do you need this fix pushed ASAP?

@mhoemmen
Copy link
Contributor Author

mhoemmen commented Aug 8, 2017

@dridzal No, but thanks for asking! You would see faster build times by disabling support for GlobalOrdinal=int, especially with ETI turned on.

@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Mar 27, 2021
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: ROL
Projects
None yet
Development

No branches or pull requests

3 participants