Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panzer: Add unique identifiers to worksets #1539

Closed
eric-c-cyr opened this issue Jul 26, 2017 · 6 comments
Closed

Panzer: Add unique identifiers to worksets #1539

eric-c-cyr opened this issue Jul 26, 2017 · 6 comments
Assignees

Comments

@eric-c-cyr
Copy link
Contributor

It would be good to have a unique identifier for each workset. This would be constructed from the WorksetDescriptor to be locally unique (with a set of Worksets defined by the descriptor). If you want a globally unique set of worksets, they could be constructed by a unordered_map.

@eric-c-cyr
Copy link
Contributor Author

Is it clear how to convert in both directions Kokkos::DynRankView <=> PHX::MDFields?

@eric-c-cyr eric-c-cyr changed the title Add unique identifiers to worksets Panzer: Add unique identifiers to worksets Jul 29, 2017
@eric-c-cyr
Copy link
Contributor Author

Also, I'm refactoring the PointValues2 class some to be more consistent with BasisValues2 and IntegrationValues2. As part of that I'm going to collapse the NODE tag into the BASIS tag. Anyone see a problem with this? Clearly this will require testing.

@eric-c-cyr
Copy link
Contributor Author

In retrospect, I don't have to do change NODE to BASIS, though I could if people think its a good idea.

@rppawlo
Copy link
Contributor

rppawlo commented Jul 31, 2017

I like the idea of changing node to basis. One less branch for possible divergence/code duplication.

@eric-c-cyr
Copy link
Contributor Author

Alright @rppawlo, my next merge commit will do this. Basically, NODE will be aliased to BASIS. We can do the sed script to totally eliminate it after that.

@eric-c-cyr
Copy link
Contributor Author

eric-c-cyr commented Jul 31, 2017

There are a few things to be done first before the core of this issue:

  • Add point descriptor
  • Convert point values to be more like basis values (no longer dependent on a templated array type, going straight to MDField)
  • Add point values to workset for evaluation of basis points
  • Add unique identifier to workset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants