-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panzer: Add unique identifiers to worksets #1539
Comments
Is it clear how to convert in both directions Kokkos::DynRankView <=> PHX::MDFields? |
Also, I'm refactoring the PointValues2 class some to be more consistent with BasisValues2 and IntegrationValues2. As part of that I'm going to collapse the NODE tag into the BASIS tag. Anyone see a problem with this? Clearly this will require testing. |
In retrospect, I don't have to do change NODE to BASIS, though I could if people think its a good idea. |
I like the idea of changing node to basis. One less branch for possible divergence/code duplication. |
Alright @rppawlo, my next merge commit will do this. Basically, NODE will be aliased to BASIS. We can do the sed script to totally eliminate it after that. |
There are a few things to be done first before the core of this issue:
|
It would be good to have a unique identifier for each workset. This would be constructed from the WorksetDescriptor to be locally unique (with a set of Worksets defined by the descriptor). If you want a globally unique set of worksets, they could be constructed by a unordered_map.
The text was updated successfully, but these errors were encountered: