Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ifpack2 FastIC&FastILDL: Crash when using non-default node type #12685

Closed
cgcgcg opened this issue Jan 23, 2024 · 7 comments
Closed

Ifpack2 FastIC&FastILDL: Crash when using non-default node type #12685

cgcgcg opened this issue Jan 23, 2024 · 7 comments
Assignees
Labels
pkg: Ifpack2 type: bug The primary issue is a bug in Trilinos code or tests

Comments

@cgcgcg
Copy link
Contributor

cgcgcg commented Jan 23, 2024

Bug Report

PR #12678 adds a test that checks that symbolic and numeric phases are respected for Ifpack2 preconditioners. As part of the new test, I ran FastIC and FastILDL on Serial node in a build with default node type Cuda. This results in

Kokkos::View ERROR: attempt to access inaccessible memory space (label="**UNAVAILABLE**")` failed.

in preconditioner apply.

@cgcgcg cgcgcg added type: bug The primary issue is a bug in Trilinos code or tests pkg: Ifpack2 labels Jan 23, 2024
Copy link

Automatic mention of the @trilinos/ifpack2 team

1 similar comment
Copy link

Automatic mention of the @trilinos/ifpack2 team

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Jan 23, 2024

@jgfouca Are you still working on the Fast* methods? If so, would you be able to have a look at this?

@jgfouca
Copy link
Contributor

jgfouca commented Jan 23, 2024

@cgcgcg , I worked on FastILU, not FastIC or FastLDL. That said, I could probably figure this out if @srajama1 wants me to look at this. I will check with him.

@jgfouca jgfouca self-assigned this Jan 23, 2024
@jgfouca
Copy link
Contributor

jgfouca commented Jan 23, 2024

@cgcgcg , I will take on this issue. Could you give me a bit more details on how to reproduce the problem? I assume I need your cgcgcg:ifpack2symbolicnumeric branch.

My cmake command (this is on weaver):

cmake -DCMAKE_BUILD_TYPE=Release -DTrilinos_ENABLE_TESTS=ON -DTrilinos_ENABLE_ShyLU=On -DTrilinos_ENABLE_ShyLU_NodeFastILU=On -DTrilinos_ENABLE_Ifpack2=On -DTrilinos_ENABLE_ShyLU_Node=On -DTrilinos_ENABLE_ShyLU_DD=On -DTrilinos_ENABLE_ShyLU_DDFROSch=On -DTPL_ENABLE_MPI=ON -DTPL_ENABLE_CUDA=ON -DKokkos_ARCH_VOLTA70=ON -DTpetra_INST_SERIAL=On ..

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Jan 23, 2024

All it should take is to run packages/ifpack2/test/unit_tests/Ifpack2_SolverFactory.exe --details=ALL.

EDIT: Oh, and uncomment these guys:

// "FAST_IC", // Fails when run with SerialNode in a build with DefaultNode=Cuda
"FAST_ILU",
"FAST_ILU_B",
// "FAST_ILDL", // Fails when run with SerialNode in a build with DefaultNode=Cuda

@cgcgcg
Copy link
Contributor Author

cgcgcg commented Feb 2, 2024

Fixed by #12703. Thanks @jgfouca!

@cgcgcg cgcgcg closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: Ifpack2 type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

2 participants