Teuchos: TEUCHOS_FUNC_TIME_MONITOR_DIFF with -Werror=shadow

[kliegeois]

Bug Report

@bartlettroscoe
@trilinos/teuchos

Description

When building the branch of #12344 with:

-D   Ifpack2_ENABLE_BlockTriDiContainer_Timers:BOOL=ON \

and the C++ flag:

-Werror=shadow

TEUCHOS_FUNC_TIME_MONITOR_DIFF does not compile because of the nesting of TEUCHOS_FUNC_TIME_MONITOR. Because, the lines https://github.com/trilinos/Trilinos/blob/master/packages/teuchos/comm/src/Teuchos_TimeMonitor.hpp#L91-L98 throw the following error:

error: declaration of 'mainblabla_localTimeMonitor' shadows a previous local

@bartlettroscoe could we use FUNCNAME in DIFF ## blabla_localTimer (I am not a macro expert)?

[bartlettroscoe]

@kliegeois, can you please copy and paste the entire build error output so that we can see the full error context? One way to do this is to just run:

$ make dashboard

and then the build error will show up on CDash (the STDOUT will give you the exact URL to the build on CDash at the very end of running that command).

[kliegeois]

@bartlettroscoe thanks for your comment!

Please find attached the asked file:
log.txt

[bartlettroscoe]

@kliegeois, sorry to only to be getting to this now (going back through my email backlog) ...

Is this still an issue? It looks like the PR:

• Ifpack2: Add Schur complements to the BlockTriDiag solver. #12344

has not been merged yet.

I see the problem is that there are two calls to IFPACK2_BLOCKHELPER_TIMER() in one function:

Trilinos/packages/ifpack2/src/Ifpack2_BlockTriDiContainer_impl.hpp

Line 852 in 67ca800

IFPACK2_BLOCKHELPER_TIMER("createPartInterface");

and

Trilinos/packages/ifpack2/src/Ifpack2_BlockTriDiContainer_impl.hpp

Line 954 in 67ca800

IFPACK2_BLOCKHELPER_TIMER("determine part Jacobi");

That is causing a shadowing warning.

One suggestion to get around this, why not just break off that code that calls the timer IFPACK2_BLOCKHELPER_TIMER("determine part Jacobi") into its own function that is called by createPartInterface(...)? That would eliminate this shadow warning and might also make this code easier to follow. (As a rule of thumb, it is nice if a function implementation can fit in a single window without having to scroll.)

That function is very long starting at:

Trilinos/packages/ifpack2/src/Ifpack2_BlockTriDiContainer_impl.hpp

Line 852 in 67ca800

IFPACK2_BLOCKHELPER_TIMER("createPartInterface");

and going all the way down to:

Trilinos/packages/ifpack2/src/Ifpack2_BlockTriDiContainer_impl.hpp

Line 1311 in 67ca800

}

with lots of detail.

@bartlettroscoe could we use FUNCNAME in DIFF ## blabla_localTimer (I am not a macro expert)?

I don't think you can use FUNCNAME because it can contain chars that are not allowed in a macro name, like : or (.

The C/C++ preprocessor language is pretty limited in the type of string manipulation you can do at pre-processing time. For example, see:

• https://learn.microsoft.com/en-us/cpp/preprocessor/preprocessor-operators?view=msvc-170