Compiler warnings for Amesos2_Superludist_FunctionMap.hpp

[BarrySmith]

/Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/bin/mpicxx -o ex63.o -c -Wall -Wwrite-strings -Wno-strict-aliasing -Wno-unknown-pragmas -g -O3 -I/Users/petsc/petsc.clone-4/include -I/Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include pwd/ex63.cxx
In file included from /Users/petsc/petsc.clone-4/src/ksp/ksp/examples/tutorials/ex63.cxx:68:
In file included from /Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2.hpp:45:
In file included from /Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Factory.hpp:102:
In file included from /Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Superludist.hpp:47:
In file included from /Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Superludist_decl.hpp:58:
/Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Superludist_FunctionMap.hpp:285:17: warning: comparison of constant 67 with expression of type 'SLUD::DiagScale_t' is always false [-Wtautological-constant-out-of-range-compare]
char eq = AMESOS2_SLUD_GET_EQUED(*equed);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Superludist_FunctionMap.hpp:71:98: note: expanded from macro 'AMESOS2_SLUD_GET_EQUED'

define AMESOS2_SLUD_GET_EQUED(ds) (((ds)==SLUD::NOEQUIL) ? 'N' : ((ds)==SLUD::ROW) ? 'R' : ((ds)=='C') ? SLUD::COL : SLUD::BOTH)

                                                                                         ~~~~^ ~~~

/Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Superludist_FunctionMap.hpp:306:17: warning: comparison of constant 67 with expression of type 'SLUD::DiagScale_t' is always false [-Wtautological-constant-out-of-range-compare]
char eq = AMESOS2_SLUD_GET_EQUED(*equed);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/petsc/petsc.clone-4/arch-osx-xsdk-opt/include/Amesos2_Superludist_FunctionMap.hpp:71:98: note: expanded from macro 'AMESOS2_SLUD_GET_EQUED'

define AMESOS2_SLUD_GET_EQUED(ds) (((ds)==SLUD::NOEQUIL) ? 'N' : ((ds)==SLUD::ROW) ? 'R' : ((ds)=='C') ? SLUD::COL : SLUD::BOTH)

                                                                                         ~~~~^ ~~~

2 warnings generated.

[BarrySmith]

Forgot to add Jason and Satish @[email protected] [email protected]

[mhoemmen]

@trilinos/amesos2

[mhoemmen]

@BarrySmith Hi Barry! We appreciate your reports! I'm not an expert on that particular file so I'm a little scared to change it myself. I've tagged the Amesos2 developers and am sure they will get back to you right away. (Many of us are new to Github and we're still learning how to use it for issue tracking. They probably didn't get a notification about this issue.)

[srajama1]

Thanks, Mark.

Barry, we'll take a look at it.

It would be nice if you can add @trilinos/amesos2 or @srajama1 in the future.

[jdbooth]

@BarrySmith Hi Barry,
May I ask which version of Superlu_DIST this was from. We have noticed some changes in the new 4.3 and want to confirm with whatever version you are using.
Thank you!
@trilinos/amesos2 @srajama1

[BarrySmith]

This is 4.3

On Feb 2, 2016, at 12:49 PM, jdbooth [email protected] wrote:

@BarrySmith Hi Barry,

May I ask which version of Superlu_DIST this was from. We have noticed some changes in the new 4.3 and want to confirm with whatever version you are using.
Thank you!

@trilinos/amesos2 @srajama1

—
Reply to this email directly or view it on GitHub.

[tjhei]

The following warning is probably related:

/ssd/libs-
candi/trilinos-12.6.1-Source/include/Amesos2_Superludist_FunctionMap.hpp:71:125:
warning: enumeral and non-enumeral type in conditional expression
[enabled by default]
((ds)==SLUD::ROW) ? 'R' : ((ds)=='C') ? SLUD::COL : SLUD::BOTH)

Let me know if you want a separate issue for it.

[srajama1]

Timo, Is this superlu_dist 4.3 as well ?

[tjhei]

I only tested SuperLU 4.1. (edit: SuperLU dist 4.1)

[srajama1]

Got it. Let me take a look.

[BarrySmith]

Yes, I get it with 4.3

On Feb 11, 2016, at 12:22 PM, Siva Rajamanickam [email protected] wrote:

Timo, Is this superlu_dist 4.3 as well ?

—
Reply to this email directly or view it on GitHub.

[srajama1]

Thanks for the report. Fixed.