Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: AT: No PRs merging due to potential communication issues and failing framework tests #10985

Closed
GrahamBenHarper opened this issue Sep 2, 2022 · 5 comments
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests

Comments

@GrahamBenHarper
Copy link
Contributor

GrahamBenHarper commented Sep 2, 2022

Bug Report

@trilinos/framework

As reported in TRILINOSHD-201, several pull requests are experiencing framework issues. Specifically, there's the following communication issue in #10983:

NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester...

After digging deeper, it's also clear that there are framework tests failing related to #10972, #10983, and more. Some output from the failing test is included below:


XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX

Advanced Test: TrilinosFrameworkTests_PullRequestLinuxDriver_UnitTests

Selected Test/CTest Properties:
  CATEGORIES = BASIC
  PROCESSORS = 1
  TIMEOUT    = DEFAULT

Creating new working directory '/scratch/trilinos/jenkins/ascic158/workspace/Trilinos_PR_python3/pull_request_test/commonTools/framework/TrilinosFrameworkTests_PullRequestLinuxDriver_UnitTests'

Running test commands: TEST_0

================================================================================

TEST_0

Running: "bash" "pr_python_test_driver.sh" "/projects/sems/install/rhel7-x86_64/sems/v2/utility/anaconda3/2020.07/gcc/7.3.0/7t6phgv/bin/python3" "pip3"

  Running in working directory "/scratch/trilinos/jenkins/ascic158/workspace/Trilinos_PR_python3/Trilinos/commonTools/framework/../../packages/framework/pr_tools"

--------------------------------------------------------------------------------


+----------------------------------------------------------+
|           P Y T H O N   T E S T   D R I V E R            |
|                                                          |
|                   2022-09-02 16:25:28                    |
+----------------------------------------------------------+


+----------------------------------------------------------+
|                P A C K A G E   S E T U P                 |
|                                                          |
|                   2022-09-02 16:25:28                    |
+----------------------------------------------------------+
--- python: /projects/sems/install/rhel7-x86_64/sems/v2/utility/anaconda3/2020.07/gcc/7.3.0/7t6phgv/bin/python3
--- pip   : pip3
PRDriver> pip executable: /projects/sems/install/rhel7-x86_64/sems/v2/utility/anaconda3/2020.07/gcc/7.3.0/7t6phgv/bin/python3 -m pip
PRDriver> 
PRDriver> /projects/sems/install/rhel7-x86_64/sems/v2/utility/anaconda3/2020.07/gcc/7.3.0/7t6phgv/bin/python3 -m pip install --user configparser
Requirement already satisfied: configparser in /home/trilinos/.local/lib/python3.8/site-packages (5.3.0)
/scratch/trilinos/jenkins/ascic158/workspace/Trilinos_PR_python3/Trilinos/packages/framework/pr_tools/common.bash: line 78: color: command not found
PRDriver> OK (3 s)


+----------------------------------------------------------+
|                E X E C U T E   T E S T S                 |
|                                                          |
|                   2022-09-02 16:25:31                    |
+----------------------------------------------------------+
--- /projects/sems/install/rhel7-x86_64/sems/v2/utility/anaconda3/2020.07/gcc/7.3.0/7t6phgv/bin/python3 -m pytest --cov=. --cov-report term-missing
ERROR: usage: __main__.py [options] [file_or_dir] [file_or_dir] [...]
__main__.py: error: unrecognized arguments: --cov=. --cov-report
  inifile: None
  rootdir: /scratch/trilinos/jenkins/ascic158/workspace/Trilinos_PR_python3/Trilinos/packages/framework/pr_tools


--- STATUS: 4

--------------------------------------------------------------------------------

TEST_0: Return code = 4
TEST_0: Pass criteria = Match any REGEX {=+ [0-9]+ passed in} [not matched]
TEST_0: Result = FAILED

================================================================================

OVERALL FINAL RESULT: TEST FAILED (TrilinosFrameworkTests_PullRequestLinuxDriver_UnitTests)

XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
@GrahamBenHarper GrahamBenHarper added type: bug The primary issue is a bug in Trilinos code or tests PA: Framework Issues that fall under the Trilinos Framework Product Area labels Sep 2, 2022
@jhux2 jhux2 pinned this issue Sep 2, 2022
@bartlettroscoe
Copy link
Member

bartlettroscoe commented Sep 6, 2022

Take a look at this query and this query. These failures have nothing to do the particular PR being tested and every PR test iteration will fail until someone does something to fix this failing test TrilinosFrameworkTests_PullRequestLinuxDriver_UnitTests.

@jhux2
Copy link
Member

jhux2 commented Sep 6, 2022

Take a look at this query and this query. These failures have nothing to do the particular PR being tested and every PR test iteration will fail until someone does something to fix this failing test TrilinosFrameworkTests_PullRequestLinuxDriver_UnitTests.

@bartlettroscoe Clicking through these two links shows exactly the error message in the description.

@jmlapre
Copy link
Member

jmlapre commented Sep 6, 2022

They are failing because the color command can't be found. If you notice in the script (common.bash) it fails due to color not being found after it installs configparser. Then it stops loading the rest of the packages and that's why the coverage is failing (it hasn't installed pytest-cov due to the earlier failure).

@jhux2 jhux2 changed the title Framework: Autotester failing during PRs due to potential communication issues and failing framework tests Framework: AT: No PRs passing due to potential communication issues and failing framework tests Sep 7, 2022
@jhux2 jhux2 changed the title Framework: AT: No PRs passing due to potential communication issues and failing framework tests Framework: AT: No PRs merging due to potential communication issues and failing framework tests Sep 7, 2022
@jhux2
Copy link
Member

jhux2 commented Sep 9, 2022

Might be fixed by #10994.

@jhux2
Copy link
Member

jhux2 commented Sep 9, 2022

This is fixed. Dashboard results before and after merge of #10994.

@jhux2 jhux2 closed this as completed Sep 9, 2022
@jhux2 jhux2 unpinned this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PA: Framework Issues that fall under the Trilinos Framework Product Area type: bug The primary issue is a bug in Trilinos code or tests
Projects
None yet
Development

No branches or pull requests

4 participants