Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fidget causes nim-lang/Nim packages CI to fail #121

Closed
ee7 opened this issue Dec 10, 2020 · 4 comments
Closed

fidget causes nim-lang/Nim packages CI to fail #121

ee7 opened this issue Dec 10, 2020 · 4 comments

Comments

@ee7
Copy link

ee7 commented Dec 10, 2020

See nim-lang/Nim@73299b0 and the log:

    Compiling /home/runner/work/Nim/Nim/pkgstemp/fidget/tests/test (from package fidget) using c backend
  /home/runner/.nimble/pkgs/typography-0.6.0/typography/font.nim(25, 22) Error: undeclared identifier: 'Segment'

It looks like this is due to a recent change in https://github.com/treeform/bumpy/ or https://github.com/treeform/pixie/.

I'll ping @guzba here, since they aren't watching this repo and it looks like they might also know how to fix it.

@treeform
Copy link
Owner

I think I fixed this. CI is green now. Please confirm in the Nim repo.

@ringabout
Copy link

ringabout commented Dec 11, 2020

see nim-lang/Nim#16319
Edited:
The PR is merged.

@timotheecour
Copy link

before closing this, would be worth investigating why CI didn't catch this

@guzba
Copy link
Contributor

guzba commented Dec 11, 2020

@timotheecour the CI doesn't run across repos which was the reason it did not catch this. The issue was treeform/typography needed a new release to depend on updated repos, then Fidget needed to depend on that new treeform/typography release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants