From b77d53dfa1fb60eb618d852cd20305cac7c85509 Mon Sep 17 00:00:00 2001 From: Michel Loiseleur <97035654+mloiseleur@users.noreply.github.com> Date: Tue, 23 Jul 2024 08:14:04 +0200 Subject: [PATCH] =?UTF-8?q?feat:=20=E2=9C=A8=20display=20release=20name=20?= =?UTF-8?q?and=20image=20full=20path=20in=20installation=20notes?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- traefik/templates/NOTES.txt | 2 +- traefik/tests/notes_test.yaml | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/traefik/templates/NOTES.txt b/traefik/templates/NOTES.txt index e3b8bcaeb..a1a10bfb3 100644 --- a/traefik/templates/NOTES.txt +++ b/traefik/templates/NOTES.txt @@ -1,6 +1,6 @@ -Traefik Proxy {{ .Values.image.tag | default .Chart.AppVersion }} has been deployed successfully on {{ template "traefik.namespace" . }} namespace ! +{{ .Release.Name }} with {{ .Values.image.registry }}/{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }} has been deployed successfully on {{ template "traefik.namespace" . }} namespace ! {{- if .Values.persistence }} {{- if and .Values.persistence.enabled (empty .Values.deployment.initContainer)}} diff --git a/traefik/tests/notes_test.yaml b/traefik/tests/notes_test.yaml index 1f30b128e..7aaa71c7c 100644 --- a/traefik/tests/notes_test.yaml +++ b/traefik/tests/notes_test.yaml @@ -16,7 +16,7 @@ tests: value: |2 - Traefik Proxy 2.3.0 has been deployed successfully on NAMESPACE namespace ! + RELEASE-NAME with docker.io/traefik:2.3.0 has been deployed successfully on NAMESPACE namespace ! - it: should use helm managed namespace in release notes output set: namespaceOverride: "traefik-ns-override" @@ -25,7 +25,7 @@ tests: value: |2 - Traefik Proxy 2.3.0 has been deployed successfully on traefik-ns-override namespace ! + RELEASE-NAME with docker.io/traefik:2.3.0 has been deployed successfully on traefik-ns-override namespace ! - it: should use tag version in release notes output if set set: image: @@ -35,7 +35,7 @@ tests: value: |2 - Traefik Proxy v3.0 has been deployed successfully on NAMESPACE namespace ! + RELEASE-NAME with docker.io/traefik:v3.0 has been deployed successfully on NAMESPACE namespace ! - it: should not display a warning when persistence and initContainer are enabled set: persistence: @@ -53,7 +53,7 @@ tests: value: |2 - Traefik Proxy 2.3.0 has been deployed successfully on NAMESPACE namespace ! + RELEASE-NAME with docker.io/traefik:2.3.0 has been deployed successfully on NAMESPACE namespace ! - it: should display warning when enabling persistence without initContainer set: persistence: @@ -63,7 +63,7 @@ tests: value: | - Traefik Proxy 2.3.0 has been deployed successfully on NAMESPACE namespace ! + RELEASE-NAME with docker.io/traefik:2.3.0 has been deployed successfully on NAMESPACE namespace ! 🚨 When enabling persistence for certificates, permissions on acme.json can be lost when Traefik restarts. You can ensure correct permissions with an @@ -83,6 +83,6 @@ tests: value: | - Traefik Proxy 2.3.0 has been deployed successfully on NAMESPACE namespace ! + RELEASE-NAME with docker.io/traefik:2.3.0 has been deployed successfully on NAMESPACE namespace ! 🚨 Resources populated with this chart don't match with labelSelector `not_here=CRD` applied on kubernetesCRD provider 🚨 🚨 Resources populated with this chart don't match with labelSelector `not_here=Ingress` applied on kubernetesIngress provider 🚨