Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to github.com/golang-jwt/jwt #1264

Closed
motoki317 opened this issue Jul 27, 2021 · 2 comments · Fixed by #1268
Closed

Migrate to github.com/golang-jwt/jwt #1264

motoki317 opened this issue Jul 27, 2021 · 2 comments · Fixed by #1268
Labels
priority/low 優先度: 低め

Comments

@motoki317
Copy link
Member

motoki317 commented Jul 27, 2021

github.com/golang-jwt/jwt を使う

  1. コード中のimportもgolang-jwt/jwtに変えてみようとする
  2. go.sumにまだ古いdgrijalva/jwt-goが残っているのに気づく → echoが古い方にまだ依存していた ref use github.com/golang-jwt/jwt labstack/echo#1916
  3. これに対処するためMIGRATION_GUIDE.mdに従って、コード中のimportは変えずgo.modのreplace directiveで対応しようとした
  4. go mod tidyをすると以下が出てダメ
❯ go mod tidy
go: finding module for package github.com/golang-jwt/jwt/test
go: finding module for package github.com/golang-jwt/jwt
go: finding module for package github.com/golang-jwt/jwt/request
go: found github.com/golang-jwt/jwt in github.com/golang-jwt/jwt v3.2.1+incompatible
go: found github.com/golang-jwt/jwt/request in github.com/golang-jwt/jwt v3.2.1+incompatible
go: found github.com/golang-jwt/jwt/test in github.com/golang-jwt/jwt v3.2.1+incompatible
go: github.com/golang-jwt/[email protected]+incompatible used for two different module paths (github.com/dgrijalva/jwt-go and github.com/golang-jwt/jwt)

†やばい事†が起こっていそう

ref #1159

@motoki317
Copy link
Member Author

移行するときallowedlist.yamlからCVEを取り除く

@motoki317
Copy link
Member Author

motoki317 commented Jul 27, 2021

もしくは、echoもtraQも該当コードを使用していない & dgrijalva/jwt-goに依存しているのが(今の所)echoだけなので、諦めて↓押しても良いかもしれない
スクリーンショット 2021-07-27 22 38 54

@motoki317 motoki317 added the priority/low 優先度: 低め label Jul 28, 2021
@motoki317 motoki317 mentioned this issue Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low 優先度: 低め
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant