Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl.conf.sample is not working as intended (since OpenSSL_1_1_0-pre1) #260

Closed
wxleong opened this issue Oct 7, 2022 · 2 comments · Fixed by #265
Closed

openssl.conf.sample is not working as intended (since OpenSSL_1_1_0-pre1) #260

wxleong opened this issue Oct 7, 2022 · 2 comments · Fixed by #265
Labels
enhancement New feature or request

Comments

@wxleong
Copy link
Member

wxleong commented Oct 7, 2022 •
edited
Loading

In openssl.conf.sample, the option ECDSA has been removed since OpenSSL_1_1_0-pre1 in this commit.

It seems harmless, but if the parser encountered an invalid option, it will exit silently. Meaning, everything come after the line default_algorithms = RSA,ECDSA are ignored.

Maybe to cleanup the openssl.conf.sample so user will not run into trouble such as pondering why SET_TCTI does not work.
@AndreasFuchsTPM AndreasFuchsTPM added the enhancement New feature or request label Nov 17, 2022
@AndreasFuchsTPM
Copy link
Member

Would you mind sending a PR on this ?

@wxleong
Copy link
Member Author

wxleong commented Nov 21, 2022 •
edited
Loading

Done, please refer to #265

@wxleong wxleong mentioned this issue Nov 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated value from openssl.conf.sample > default_algorithms wxleong/tpm2-tss-engine
2 participants
@AndreasFuchsTPM @wxleong