Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more configurable grpc tracer #126

Closed
tamuhey opened this issue Aug 23, 2021 · 1 comment · Fixed by #189
Closed

more configurable grpc tracer #126

tamuhey opened this issue Aug 23, 2021 · 1 comment · Fixed by #189
Assignees
@davidpdrsn
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR.
Milestone
0.2.0

Comments

@tamuhey
Copy link

tamuhey commented Aug 23, 2021 •
edited
Loading

Feature Request

GrpcErrorsAsFailures classifies all non-zero status responses as Failure.
However, there are times when I want to classify InvalidArgument status as a non-failure because it is a user error.

Alternatives

Currently, I copy & paste the GrpcErrorsAsFailures code and modify the classification flow.
@davidpdrsn davidpdrsn added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Aug 23, 2021
@davidpdrsn davidpdrsn added this to the 0.2.0 milestone Nov 8, 2021
@MarcusGrass
Copy link
Collaborator

I think I'll take a stab at this, trying not to create a monster

@davidpdrsn davidpdrsn self-assigned this Nov 25, 2021
@davidpdrsn davidpdrsn mentioned this issue Nov 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidpdrsn davidpdrsn

Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Make GrpcErrorsAsFailures more flexible tower-rs/tower-http
3 participants
@davidpdrsn @tamuhey @MarcusGrass