Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/as-bind.d.ts doesn't match signature of lib/lib.js #52

Closed
kevin-lindsay-1 opened this issue Nov 4, 2020 · 2 comments · Fixed by #57
Closed

lib/as-bind.d.ts doesn't match signature of lib/lib.js #52

kevin-lindsay-1 opened this issue Nov 4, 2020 · 2 comments · Fixed by #57
Labels
bug Something isn't working

Comments

@kevin-lindsay-1
Copy link

Looks like the .d.ts only exports an interface, not a constant, and as a result AsBind gets the dreaded red squiggly when you try to use it as a value.

@torch2424 torch2424 self-assigned this Nov 6, 2020
@torch2424 torch2424 added the bug Something isn't working label Nov 6, 2020
@torch2424 torch2424 removed their assignment Nov 6, 2020
@torch2424
Copy link
Owner

Ah! Thanks for opening this issue! 😄 Ah yeah, this was brought up by someone else recently, but I haven't had the chance to update the typings file.

Feel free to open a PR in the meantime, or I can get to it once I get the time 😄 👍

This was referenced Nov 11, 2020
@torch2424
Copy link
Owner

Fixed and published in 0.5.0 😄

Unfortunately, I just exported an any for now to stop the "red squiggly", but I opened #56 as I think the library should just be written in TypeScript anyways 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants