Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bars in QTerminal/Konsole #1064

Closed
tonsky opened this issue Jun 3, 2020 · 8 comments
Closed

Progress bars in QTerminal/Konsole #1064

tonsky opened this issue Jun 3, 2020 · 8 comments

Comments

@tonsky
Copy link
Owner

tonsky commented Jun 3, 2020

This still happens on progress bars of some command-line programs. Can it be fixed in any way?

For example this is a progress bar that appears when loading a docker image with docker load:

image

Originally posted by @nilp0inter in #968 (comment)

@nilp0inter
Copy link

nilp0inter commented Jun 3, 2020

Continuing with the conversation in #968, I tested the font in the suggested code editors and it works as expected:

In Sublime it works in the text editor as well as in the Terminus plugin.

image

In VSCode ligatures work in the editor but not in the terminal (although maybe I am missing some configuration option)

image

@nilp0inter
Copy link

kitty works!

image

@nilp0inter
Copy link

Patched st works too.

image

I am afraid I can't check more terminals in my setup easily.

Given the results I suspect the bug is maybe related to Qt?

@wopian
Copy link
Contributor

wopian commented Jun 3, 2020

but not in the [vscode] terminal (although maybe I am missing some configuration option)

Current terminal rendering system used (xterm.js) doesn't support ligatures - microsoft/vscode#34103.

Although this reminded me to check my bookmarked issues for this and ligatures may be back in the vscode terminal soon (ligature support got merged into xterm.js in May) 🎉

@tonsky
Copy link
Owner Author

tonsky commented Jun 3, 2020

Cool! That means that the issue with terminals themselves (QTerminal/Konsole), not the font. Consider reporting the issue to them

@nilp0inter
Copy link

I'll do, thank you!

@nilp0inter
Copy link

Here are the issue reports in case anybody ends here:

@tonsky tonsky closed this as completed Jun 3, 2020
@nilp0inter
Copy link

Hi again,

a new piece of information has been added by one of QTerminal developers here: lxqt/qterminal#684 (comment)

Both bugs appears to be related to Qt not classifying FiraCode as a monospace font. Maybe some metadata is missing in FiraCode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants