Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim whitespace between values when reading from configuration from runsettings #679

Merged
merged 4 commits into from
Jan 15, 2020
Merged

Trim whitespace between values when reading from configuration from runsettings #679

merged 4 commits into from
Jan 15, 2020

Conversation

EricStG
Copy link
Contributor

@EricStG EricStG commented Jan 8, 2020 •
edited
Loading

Closes #641

@MarcoRossignoli MarcoRossignoli added the enhancement General enhancement request label Jan 10, 2020
@MarcoRossignoli
Copy link
Collaborator

Thank's I'll review asap!

@EricStG
Updated settings parser to better handle nulls
0ade9d3 
Improved settings parser test coverages
MarcoRossignoli
MarcoRossignoli approved these changes Jan 15, 2020
View reviewed changes
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank's!

@MarcoRossignoli MarcoRossignoli merged commit 492b8a9 into coverlet-coverage:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

Assignees
No one assigned
Labels
enhancement General enhancement request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In coverlet.collector, allow repeating configuration elements in runsettings
2 participants
@EricStG @MarcoRossignoli