Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT Swap Contract #32

Closed
Naltox opened this issue Aug 29, 2022 · 9 comments
Closed

NFT Swap Contract #32

Naltox opened this issue Aug 29, 2022 · 9 comments
Assignees
@xssnick
Labels
Approved This proposal is approved by the committee footstep This is a TON Footstep issue

Comments

@Naltox
Copy link

Naltox commented Aug 29, 2022 •
edited by delovoyhomie
Loading

Summary

Develop smart-contract for swapping NFT's

Context

Sometimes users don’t want to sell their NFT but are ready to exchange it for other NFT(s).
This is exactly what we want to achieve here.

FYI: this grand is funded by Getgems & Tegro NFT

Goals

  • develop smart contract which allows users to swap their NFT's

Deliverables

  • contract itsels
  • tests
  • docs

Technical requirements could be found here: https://telegra.ph/NFT-swap-Contract-Product-Description--Technical-requirements-08-24

Definition of Done

  • NFT marketplaces on TON are able to implement NFT swap mechanics on top of this contract

Reward

  • 2000 TON

Total: $3700
@Naltox Naltox added the footstep This is a TON Footstep issue label Aug 29, 2022
@Hiyorimi Hiyorimi added the Approved This proposal is approved by the committee label Aug 29, 2022
@xssnick
Copy link
Contributor

xssnick commented Aug 29, 2022

Im ready to implement

@Hiyorimi Hiyorimi assigned Hiyorimi and xssnick and unassigned Hiyorimi Aug 30, 2022
@Hiyorimi
Copy link
Contributor

Great! Looking forward to finishing it!

@DeFiTON
Copy link

DeFiTON commented Sep 1, 2022

Im ready to implement

We look forward to your work

@Naltox
Copy link
Author

Naltox commented Sep 6, 2022

Let's add a bonus task: +500 TON if @xssnick would implement swapping NFT with surcharge.
This means user A is ready to swap his NFT on other one plus some extra coins

@xssnick
Copy link
Contributor

xssnick commented Sep 6, 2022

Will add surcharge to implementation

@xssnick
Copy link
Contributor

xssnick commented Sep 7, 2022

Done! Contract + Tests + Docs

PR https://github.com/getgems-io/nft-contracts/pull/8/files

@Hiyorimi
Copy link
Contributor

Hiyorimi commented Sep 8, 2022 •
edited
Loading

Done! Contract + Tests + Docs

PR https://github.com/getgems-io/nft-contracts/pull/8/files

Awesome! Thank you!

Can you please submit a PR to Footsteps repo?

@xssnick
Copy link
Contributor

xssnick commented Sep 9, 2022

@Hiyorimi #36

Hiyorimi added a commit that referenced this issue Sep 11, 2022
@Hiyorimi
Merge pull request #36 from xssnick/main
564455b 
PR for #23 & #32 implementing NFT Swaps and SBTs
@Hiyorimi
Copy link
Contributor

Closed with #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xssnick xssnick

Labels
Approved This proposal is approved by the committee footstep This is a TON Footstep issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Hiyorimi @DeFiTON @Naltox @xssnick