ember-data master Rollup build error

[xg-wang]

23:51:45 in ember-cli-fastboot on  master [!] is 📦 v2.0.0 via 🐹 3.3.0 took 40s
[I] ➜ yarn test
yarn run v1.10.1
$ mocha && ember test


  rewriting HTML
    1) builds an index.html that points to the browser build
cleaning up...

Build failed.

Build Error (Rollup)


Could not resolve './references/record' from tmp/rollup-cache_path-23iVf97F.tmp/build/-private/system/references.js

Also failed a new kicked travis-ci https://travis-ci.com/xg-wang/ember-cli-fastboot/jobs/160253348

[xg-wang]

Some commit in ember-data#master caused this, I don't see this error yesterday.
cc @runspired @kellyselden

[kellyselden]

Can we close this since it's not an issue here?

[runspired]

We don’t know it’s not an issue here, only that apparently ember-data master and here are not compatible. Both do weird build things.

[kellyselden]

OK thanks for the heads up.

[mistahenry]

ember-cli-addon-tests/lib/utilities/pristine.js

Lines 97 to 98 in 5d4cea6

	emberVersion: options.emberVersion || 'canary',
	emberDataVersion: options.emberDataVersion || 'emberjs/data#master'

This seems like a risky default. Any reason not to use latest instead?

[igorT]

emberjs/data#5757 is the commit which broke it

[runspired]

I've confirmed that new apps using ember-data master do not break due to the above ember-data commit, only things using ember-cli-addon-tests, so it's not necessarily a fundamental issue with how ember-data is configured to build / publish: it may be an issue with how this repo is consuming it.

Edit: To clarify: what I tested was an app specifying canary via use of "ember-data": "emberjs/data#master" in it's package.json

[runspired]

Update: We don't fail when installing canary via yarn, but we DO fail on a new app when installing canary via npm.

[runspired]

@igorT found this yarnpkg/yarn#2090 which means this IS an issue with ember-data as we need to find a way to publish that won't blow up for npm and won't blow up if yarn is fixed to respect .npmignore on installs from git artifacts.

[igorT]

Should be fixed now

[rwjblue]

Why is this repo using non-released versions of ember-data at all? If we must do this then we will need to setup tarball publishing along the lines of what ember-source does.