Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

What is AsyncGettingStarted ? #247

Closed
MoOx opened this issue May 6, 2016 · 2 comments
Closed

What is AsyncGettingStarted ? #247

MoOx opened this issue May 6, 2016 · 2 comments

Comments

@MoOx
Copy link

MoOx commented May 6, 2016

I saw this in react-google-maps/lib/async/ScriptjsLoader examples.
I found this

react-google-maps/examples/gh-pages/src/pages/AsyncGettingStarted.js

Line 16 in 5e672b9

static version = Math.ceil(Math.random() * 22);
but this sound unreal.

Why ScriptjsLoader does not provide default values for hostname, pathname etc?
@tomchentw
Copy link
Owner

Good question! Yeah! ScriptjsLoader should provide some default values for hostname/pathname since they're rarely changed.

For the random version in example, it's used in development of ScriptjsLoader but I should remove it.

@tomchentw tomchentw mentioned this issue May 29, 2016
Open
@tomchentw
Copy link
Owner

We're also looking for maintainers. Involve in #266 to help strengthen our community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MoOx @tomchentw