From 6c5992b442b2eade01761f1c2c0a435aa4b56c9b Mon Sep 17 00:00:00 2001 From: Tomas Bjerre Date: Sun, 16 Jun 2019 09:41:56 +0200 Subject: [PATCH] commentOnlyChangedFiles --- CHANGELOG.md | 5 +++++ build.gradle | 2 +- .../comments/gitlab/lib/GitLabCommentsProvider.java | 7 ++++++- .../gitlab/lib/ViolationCommentsToGitLabApi.java | 11 +++++++++++ 4 files changed, 23 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 87abd35..83f3065 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,11 @@ Changelog of Violation comments to gitlab lib. ## Unreleased ### No issue +**Gradle 5** + + +[41188ff96a35e6d](https://github.com/tomasbjerre/violation-comments-to-gitlab-lib/commit/41188ff96a35e6d) Tomas Bjerre *2019-06-12 19:39:14* + **doc** diff --git a/build.gradle b/build.gradle index 00d4c2e..13aa1ff 100644 --- a/build.gradle +++ b/build.gradle @@ -19,7 +19,7 @@ apply from: project.buildscript.classLoader.getResource('release.gradle').toURI( dependencies { - compile 'se.bjurr.violations:violation-comments-lib:1.95' + compile 'se.bjurr.violations:violation-comments-lib:1.97' compile 'org.gitlab4j:gitlab4j-api:4.9.18' testCompile 'junit:junit:4.12' testCompile 'org.assertj:assertj-core:2.3.0' diff --git a/src/main/java/se/bjurr/violations/comments/gitlab/lib/GitLabCommentsProvider.java b/src/main/java/se/bjurr/violations/comments/gitlab/lib/GitLabCommentsProvider.java index e71d147..6e1c0b3 100644 --- a/src/main/java/se/bjurr/violations/comments/gitlab/lib/GitLabCommentsProvider.java +++ b/src/main/java/se/bjurr/violations/comments/gitlab/lib/GitLabCommentsProvider.java @@ -92,7 +92,7 @@ private Map getProxyConfig(final ViolationCommentsToGitLabApi ap } @Override - public void createCommentWithAllSingleFileComments(final String comment) { + public void createComment(final String comment) { markMergeRequestAsWIP(); try { this.gitLabApi @@ -308,4 +308,9 @@ public Integer getMaxNumberOfViolations() { public Integer getMaxCommentSize() { return api.getMaxCommentSize(); } + + @Override + public boolean shouldCommentOnlyChangedFiles() { + return api.getShouldCommentOnlyChangedFiles(); + } } diff --git a/src/main/java/se/bjurr/violations/comments/gitlab/lib/ViolationCommentsToGitLabApi.java b/src/main/java/se/bjurr/violations/comments/gitlab/lib/ViolationCommentsToGitLabApi.java index a18794f..fd97730 100644 --- a/src/main/java/se/bjurr/violations/comments/gitlab/lib/ViolationCommentsToGitLabApi.java +++ b/src/main/java/se/bjurr/violations/comments/gitlab/lib/ViolationCommentsToGitLabApi.java @@ -54,6 +54,7 @@ public void log(final Level level, final String string, final Throwable t) { private String proxyPassword; private Integer maxNumberOfViolations; private Integer maxCommentSize; + private boolean shouldCommentOnlyChangedFiles = true; public ViolationCommentsToGitLabApi setViolationsLogger(final ViolationsLogger violationsLogger) { this.violationsLogger = violationsLogger; @@ -148,6 +149,10 @@ public boolean getCommentOnlyChangedContent() { return commentOnlyChangedContent; } + public boolean getShouldCommentOnlyChangedFiles() { + return shouldCommentOnlyChangedFiles; + } + public boolean getCreateCommentWithAllSingleFileComments() { return createCommentWithAllSingleFileComments; } @@ -190,6 +195,12 @@ public ViolationCommentsToGitLabApi setShouldKeepOldComments( return this; } + public ViolationCommentsToGitLabApi withShouldCommentOnlyChangedFiles( + final boolean shouldCommentOnlyChangedFiles) { + this.shouldCommentOnlyChangedFiles = shouldCommentOnlyChangedFiles; + return this; + } + public boolean getShouldKeepOldComments() { return shouldKeepOldComments; }