Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the "smiling face with tear" emoji #46

Closed
waldyrious opened this issue Aug 13, 2021 · 2 comments
Closed

Add the "smiling face with tear" emoji #46

waldyrious opened this issue Aug 13, 2021 · 2 comments

Comments

@waldyrious
Copy link
Contributor

There are some emoji missing from the list, and Smiling face with tear is one of them. → 🥲

I noticed similar issues, like #34 and #19. It would be nice to have some guidance on the README about how to add new emoji, or whether that depends on upstream updates. For example, would changes like those of f6fec5a work generally? Are the emoji that can be added limited to a specific Unicode version? Etc.

If some pointers are provided, I'd be happy to submit a PR!
@tom-james-watson
Copy link
Owner

I'm going to close this in favour of #47, which would add all of these recent emojis.

@tom-james-watson
Copy link
Owner

Unfortunately I think this still wouldn't display properly in the app until we work out how to do #48, so I probably we have to hide the most recent emojis still.

@waldyrious waldyrious mentioned this issue Aug 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@waldyrious @tom-james-watson