Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pasting in Wayland redux #157

Open
protist opened this issue Jun 19, 2024 · 20 comments · May be fixed by #161
Open

Pasting in Wayland redux #157

protist opened this issue Jun 19, 2024 · 20 comments · May be fixed by #161

Comments

@protist
Copy link

protist commented Jun 19, 2024 •
edited
Loading

I know Wayland has been discussed here before, but I think there is a way to paste emoji.

Emote is already using wl-clipboard, specifically wl-copy to copy the emoji. Hence, it should be straightforward to use wl-paste from the same repository.

Having said that, I tried messing with Emote's code, but I couldn't get it to work. I tried variations on the following.

--- a/emote/picker.py	2024-05-17 20:40:02.000000000 +1000
+++ b/emote/picker.py	2024-06-19 22:28:28.977476352 +1000
@@ -648,9 +648,13 @@
 
         self.destroy()
 
+        time.sleep(0.15)
         if not config.is_wayland:
-            time.sleep(0.15)
             os.system("xdotool key ctrl+v")
+        else:
+            os.system("wl-paste")
 
     def add_emoji_to_recent(self, emoji):
         user_data.update_recent_emojis(emoji)

but nothing ever pasted. FWIW I don't entirely understand how the code works here. Even in X11, isn't the "ctrl+v" operating while Emote is still in the foreground? I tried increasing the sleep, but this just delays how long the Emote window stays open.

Another option could be using ydotool, e.g. pasting with

+            os.system("ydotool key 29:1 47:1 47:0 29:0")

or even better, bypassing the clipboard and directly

+            os.system("ydotool type " + emoji)

However, neither of these worked for me either.
@nightgolfer
Copy link

Hope a solution is found, really miss Emote working properly now that I've gone to Fedora 40 and Wayland is default 😓

@theamazing0
Copy link

Running "wl-paste" in the terminal seems to just be printing the current clipboard content in the terminal, not pasting it at the current cursor location.

@protist
Copy link
Author

protist commented Aug 20, 2024

@theamazing0 I'm not sure what you mean. If you are typing wl-paste in the terminal, then isn't the terminal the "current cursor location"? Either way, this is essentially what the emote code already did with xdotool key ctrl+v.

(If you want to test it in another location, try something like sleep 1 ; wl-paste in the terminal, then quickly change the cursor location elsewhere.)

@theamazing0
Copy link

Yes, that's what I did. I ran the command to sleep and then wl-paste, and changed my cursor location to somewhere else in Firefox.

I just read further, and saw you also tried ydotool, did these commands work if you ran them directly in the terminal?

@ZimbiX
Copy link

ZimbiX commented Aug 21, 2024 •
edited
Loading

Running "wl-paste" in the terminal seems to just be printing the current clipboard content in the terminal, not pasting it at the current cursor location.

I was going to comment the same thing yesterday! (I tried it by prefixing sleep, obviously). In the wl-paste usage shown in the wl-clipboard readme, the paste output is being piped to other commands, so it looks like simply outputting the clipboard to stdout is its intended functionality.

Edit: So wl-paste looks more equivalent to MacOS's pbpaste

@ZimbiX
Copy link

ZimbiX commented Aug 21, 2024 •
edited
Loading

For pasting to support terminal as well, I'm trying using Ctrl+Shift+V. That shortcut works in Kitty, Chrome, and Firefox; though not Dolphin, Nautilus, or Gnome Settings (but that's acceptable for my usage).

ydotool key 29:1 42:1 47:1 47:0 42:0 29:0

I noticed in /usr/include/linux/input-event-codes.h there is a code for KEY_PASTE, but it doesn't seem to do anything.

ZimbiX added a commit to ZimbiX/Emote that referenced this issue Aug 21, 2024
@ZimbiX
Paste selected emoji using ydotool on Wayland
94f0412 
Resolves tom-james-watson#157.

Related: tom-james-watson#44.

ydotool must be installed with ydotoold running
@ZimbiX ZimbiX linked a pull request Aug 21, 2024 that will close this issue
Open
@ZimbiX
Copy link

ZimbiX commented Aug 21, 2024

PR submitted

@theamazing0
Copy link

Shouldn't the Wayland behavior be consistent with X? If it should be Ctl+v or Ctrl+Shift+v should be another issue, as the current X behavior is to use Ctrl+v, and the Wayland behavior should do the same thing for now.

@protist
Copy link
Author

protist commented Aug 21, 2024 •
edited
Loading

Sorry for double-posting. Much of my original comment is redundant to due more research. I've deleted that comment and added a new one here.

Apologies @theamazing0 and @ZimbiX, you are totally correct. wl-paste does indeed send to std out. The command I use in general is

ydotool type -d0 "$(wl-paste)"

I think this strategy is probably slightly neater than using ydotool to send a literal ctrl-v or ctrl-shift-v, because it's more direct. It doesn't depend on specific keyboard shortcuts of the program (as stated above by @ZimbiX ), and also it has less chance of failing if the user has another modifier held down. Even better is bypassing the clipboard as per my OP, i.e. using ydotool to directly type the emoji. This has even less chance of failing, and also doesn't pollute the clipboard.

However, ydotool cannot type emoji, so that won't be an option. OTOH apparently wtype can type emoji, but this program doesn't work on KDE nor Gnome. Other alternatives are dotool and kdotool. I can have a look at these later.

@ZimbiX Your trick of backgrounding the command with & works well for me. I could get emote working with a similar strategy. FWIW ctrl-shift-v doesn't work in the programs I use, so I modified it to ctrl-v instead. i.e.

os.system('bash -c "sleep 1; ydotool key 29:1 47:1 47:0 29:0" &')

EDIT: after more research, kdotool can't type characters, and dotool doesn't seem to work for emoji, giving me the error dotool: WARNING: impossible character for layout: 😰. So it looks like the only remaining solution is using ydotool to type ctrl-v (or ctrl-shift-v, which doesn't work for many of my programs).

@tom-james-watson
Copy link
Owner

Hey all - thanks for thinking about this stuff - it would be awesome if we could get this working!

See #161 (comment) - the difficult part is packaging the app so that this works out of the box with flatpak and/or snap, not just the invocation of the utils themselves.

@protist
Copy link
Author

protist commented Aug 21, 2024

Thanks @tom-james-watson . I don't know a lot about it, but I suspect that the way Wayland works is to require a root daemon for security reasons. I think some of the other programs (e.g. dotool) also have a root component. Hence I suspect there's no way for a non-privileged user-installed version to paste in Wayland.

If that is the case, could we just check for a running instance of ydotool, then if that exists use the ydotool command? Or maybe just run ydotool and let if fail if it fails. Otherwise the alternative is patching it in every distro, which doesn't seem optimal either.

@tom-james-watson
Copy link
Owner

I think it's likely solvable in snap/flatpak directly, by someone with enough knowledge.

I don't really want to ship features that require the user to manually install other packages and set up systemd services and things like that.

@protist
Copy link
Author

protist commented Aug 21, 2024

Fair enough. I don't user snap/flatpack, but I just realised that it's possible to install them with root privileges, so you are probably correct that there might be a solution.

@tom-james-watson
Copy link
Owner

Snap and Flatpak are the only officially supported installation methods, so any code changes need to work for them specifically.

@MorsMortium
Copy link

The backend of maliit keyboard could also be used. https://github.com/maliit/keyboard

@MorsMortium
Copy link

Pasting works on recent plasma wayland (6.2.3)

@tom-james-watson
Copy link
Owner

I don't think that's possible. The code skips pasting if you're running wayland, and if not will use xdotool, which only supports X11.

@MorsMortium
Copy link

I just noticed I had ydotoold running for another reason. When I stop it, it no longer works

@MorsMortium
Copy link

Alright, it's from AUR packagers patch, sorry for noise: https://aur.archlinux.org/cgit/aur.git/tree/emote_wayland_autopaste.patch?h=emote

@MorsMortium
Copy link

Btw, at least on artix ydotoold isn't needed to be run as root

@angelhdzdev angelhdzdev mentioned this issue Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Paste selected emoji using ydotool on Wayland ZimbiX/Emote
6 participants
@protist @ZimbiX @tom-james-watson @nightgolfer @MorsMortium @theamazing0