From 175d7969b1f75ab797aff9c92a70d845297444ad Mon Sep 17 00:00:00 2001 From: Miedviediev Dmytro Date: Sat, 21 Oct 2023 01:15:40 +0300 Subject: [PATCH] fix: Make generated temp table name escaped (#3797) * Fix critical issue with saving results in BigQuery Need to encapsulate table path as tmp table path can contain symbols that can't be process by BigQuery without encapsulation Signed-off-by: Dmytro Miedviediev * update numpy Signed-off-by: Dmytro Miedviediev * revert numpy version Signed-off-by: Dmytro Miedviediev --------- Signed-off-by: Dmytro Miedviediev --- sdk/python/feast/infra/offline_stores/bigquery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py index 86c587c7fd..10c8aa783f 100644 --- a/sdk/python/feast/infra/offline_stores/bigquery.py +++ b/sdk/python/feast/infra/offline_stores/bigquery.py @@ -515,7 +515,7 @@ def to_bigquery( temp_dest_table = f"{tmp_dest['projectId']}.{tmp_dest['datasetId']}.{tmp_dest['tableId']}" # persist temp table - sql = f"CREATE TABLE `{dest}` AS SELECT * FROM {temp_dest_table}" + sql = f"CREATE TABLE `{dest}` AS SELECT * FROM `{temp_dest_table}`" self._execute_query(sql, timeout=timeout) print(f"Done writing to '{dest}'.")