Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken link on docs.rs #3003

Closed
c-git opened this issue Jun 10, 2024 · 3 comments
Closed

Broken link on docs.rs #3003

c-git opened this issue Jun 10, 2024 · 3 comments

Comments

@c-git
Copy link

c-git commented Jun 10, 2024

Bug Report

Version

0.1.40

Platform

Using Firefox.

Description

I was reviewing the documentation on docs.rs and was reading the page for the instrument macro and clicked on the link for the Value trait. It has an extra . at the end of the link but I'm not sure why. I cloned the repo on my local machine and couldn't reproduce the problem so I wasn't able to send a PR to fix it. I'm not sure if I should have created the issue on docs.rs instead but wasn't even sure where I would do that. So creating this and hoping someone can help or point me in the right direction for how to fix it. (Or just occurred to me maybe it's already been fixed which is why I can't reproduce it.)

Actual link on docs.rs that doesn't work https://docs.rs/tracing/latest/tracing/field/trait.Value.html.
Link that works (similar to what I get locally) https://docs.rs/tracing/latest/tracing/field/trait.Value.html

Screenshot of what I get from the first (not working) link is below

screenshot

@mladedav
Copy link
Contributor

The last release of tracing was 8 months ago so there's a chance someone else fixed it and that's why you can't reproduce it. So maybe try on the tagged commit of the release if you didn't.

@kaffarell
Copy link
Contributor

kaffarell commented Jun 11, 2024

Yep, this has been fixed on v0.1.x: #2780

@c-git
Copy link
Author

c-git commented Jun 12, 2024

Ok thanks for the confirmation.

@c-git c-git closed this as completed Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants