You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What crate(s) in this repo are involved in the problem?
tokio-console
What is the issue?
Although the output seems correct for this 'app' example, it actually isn't. The problem arises because when we use the spawn function, it uses std::panic::Location::caller to get the file location. I printed the location we received from the console-subscriber on Windows, which is console-subscriber\examples\app.rs:68:10. Unfortunately, this doesn't match the regex, so we end up calling toString(), which results in console-subscriber\examples\app.rs:68:10.
To fix this problem, I will test more cases on Windows and improve the regex to support Windows path. But I don't think we should do it in this PR. I will open a new PR to fix it.
What crate(s) in this repo are involved in the problem?
tokio-console
What is the issue?
Although the output seems correct for this 'app' example, it actually isn't. The problem arises because when we use the spawn function, it uses std::panic::Location::caller to get the file location. I printed the location we received from the console-subscriber on Windows, which is console-subscriber\examples\app.rs:68:10. Unfortunately, this doesn't match the regex, so we end up calling toString(), which results in console-subscriber\examples\app.rs:68:10.
How can the bug be reproduced?
Run tokio-console on the Windows.
Logs, error output, etc
No response
Versions
Possible solution
To fix this problem, I will test more cases on Windows and improve the regex to support Windows path. But I don't think we should do it in this PR. I will open a new PR to fix it.
Additional context
ref #541 (comment)
Would you like to work on fixing this bug?
yes
The text was updated successfully, but these errors were encountered: